Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-13518: assign only system which are in candlepin #1512

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

MichaelMraka
Copy link
Collaborator

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Oct 15, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-13518

@MichaelMraka MichaelMraka requested a review from psegedy October 15, 2024 11:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.43%. Comparing base (1a55ecd) to head (76d0fbb).

Files with missing lines Patch % Lines
manager/controllers/template_systems_update.go 56.00% 6 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1512      +/-   ##
==========================================
- Coverage   63.45%   63.43%   -0.02%     
==========================================
  Files         114      114              
  Lines        9637     9651      +14     
==========================================
+ Hits         6115     6122       +7     
- Misses       2980     2985       +5     
- Partials      542      544       +2     
Flag Coverage Δ
unittests 63.43% <63.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy
Copy link
Member

psegedy commented Dec 2, 2024

/retest

@MichaelMraka MichaelMraka requested a review from psegedy December 3, 2024 09:35
@MichaelMraka MichaelMraka merged commit 8a837c9 into RedHatInsights:master Dec 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants