Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-13828: add system tags to notification context #1531

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Nov 11, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@psegedy psegedy requested a review from MichaelMraka November 11, 2024 17:31
Copy link

jira-linking bot commented Nov 11, 2024

Commits missing Jira IDs:
c6a7d6a
Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-13828

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.46%. Comparing base (7375035) to head (c6a7d6a).

Files with missing lines Patch % Lines
evaluator/notifications.go 55.55% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1531      +/-   ##
==========================================
- Coverage   63.50%   63.46%   -0.04%     
==========================================
  Files         114      114              
  Lines        9609     9632      +23     
==========================================
+ Hits         6102     6113      +11     
- Misses       2970     2978       +8     
- Partials      537      541       +4     
Flag Coverage Δ
unittests 63.46% <57.14%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy merged commit 9b24d4c into RedHatInsights:master Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants