Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-14390: rewrite on_system_update trigger without locking #1535

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Nov 22, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@psegedy psegedy requested a review from MichaelMraka November 22, 2024 16:25
Copy link

jira-linking bot commented Nov 22, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-14390

@psegedy psegedy removed the request for review from MichaelMraka November 22, 2024 17:30
@psegedy psegedy force-pushed the aad_insert_deadlock branch from f7652bb to 8253143 Compare November 26, 2024 13:34
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 8.69565% with 21 lines in your changes missing coverage. Please review.

Project coverage is 63.31%. Comparing base (909e0ce) to head (c6fa0a2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
tasks/cleaning/clean_advisory_account_data.go 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1535      +/-   ##
==========================================
- Coverage   63.45%   63.31%   -0.14%     
==========================================
  Files         114      115       +1     
  Lines        9637     9659      +22     
==========================================
+ Hits         6115     6116       +1     
- Misses       2980     3001      +21     
  Partials      542      542              
Flag Coverage Δ
unittests 63.31% <8.69%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy force-pushed the aad_insert_deadlock branch from 8253143 to c6fa0a2 Compare November 27, 2024 11:49
@psegedy
Copy link
Member Author

psegedy commented Nov 27, 2024

/retest

3 similar comments
@psegedy
Copy link
Member Author

psegedy commented Dec 2, 2024

/retest

@psegedy
Copy link
Member Author

psegedy commented Dec 2, 2024

/retest

@psegedy
Copy link
Member Author

psegedy commented Dec 2, 2024

/retest

@psegedy psegedy merged commit b38ae53 into RedHatInsights:master Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants