Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-14351: add system authenticated API for templates #1539

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

MichaelMraka
Copy link
Collaborator

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Dec 3, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-14351

@MichaelMraka MichaelMraka marked this pull request as draft December 3, 2024 14:46
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 67.16418% with 22 lines in your changes missing coverage. Please review.

Project coverage is 63.68%. Comparing base (a845aa7) to head (2abe489).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
.../controllers/template_subscribed_systems_update.go 65.38% 13 Missing and 5 partials ⚠️
manager/middlewares/authentication.go 73.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1539      +/-   ##
==========================================
+ Coverage   63.33%   63.68%   +0.35%     
==========================================
  Files         115      116       +1     
  Lines        9673     9740      +67     
==========================================
+ Hits         6126     6203      +77     
+ Misses       3003     2986      -17     
- Partials      544      551       +7     
Flag Coverage Δ
unittests 63.68% <67.16%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -6611,7 +6682,7 @@
}
]
},
"put": {
"patch": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean that "/templates/{template_id}/systems" PUT won't be documented but will still work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly :)

Copy link
Member

@psegedy psegedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it looks good

@MichaelMraka MichaelMraka force-pushed the pr2 branch 2 times, most recently from 3120ce9 to ca38a9e Compare December 6, 2024 13:49
@MichaelMraka MichaelMraka marked this pull request as ready for review December 9, 2024 13:16
@MichaelMraka MichaelMraka merged commit a1c1af9 into RedHatInsights:master Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants