Add support for itless base layout dashboard type #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally with changes to chrome-service and things appear to be working as expected. Chrome service PR will be opened by @SteveHNH |
Hyperkid123
reviewed
Nov 21, 2024
| @@ -100,6 +101,12 @@ const GridLayout = ({ isLayoutLocked = false, layoutType = 'landingPage' }: { is | |||
| const addNotification = useAddNotification(); | |||
| const setCurrentlyUsedWidgets = useSetAtom(currentlyUsedWidgetsAtom); | |||
| const { analytics } = useChrome(); | |||
| const isITLess = useFlag('platform.widget-layout.itless'); | |||
There was a problem hiding this comment.
Hmmm
I wonder if we could pass this string as a prop from the fed-modules config as we are doing for learning resources.
Its much cleaner and we do not need a feature flag on frontend all.
There was a problem hiding this comment.
That sounds great to me. I'd rather avoid having to use featureFlags if I can avoid it. It makes sense to load this from the frontend deploy file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently updated chrome-service backend to remove widgets from the widget mapping based on feature flag (see: RedHatInsights/chrome-service-backend#716). However, those widgets still appear in the forked base template. The widgets are not rendered by the UI - however there are large chunks of whitespace in the grid (where those widgets would have been).
There are a few options to resolve this:
patchthe layout to remove these items. IMO this could cause undesirable bugs however (how do we know when a widget should actually be removed or there is a configuration issue?)sm,md, etc) for the widgets (unless we add a new item to the schema).