-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the massive upload #13
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
collective/limitfilesizepanel/browser/folder_contents_upload.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # -*- coding: utf-8 -*- | ||
| from plone import api | ||
| from plone.app.content.browser.file import FileUploadView as BaseFileUploadView | ||
|
|
||
| import mimetypes | ||
|
|
||
|
|
||
| class FileUpload(BaseFileUploadView): | ||
| """ | ||
| Add filetype validation for folder_contents massive upload view. | ||
| This view is a merge from collective.limitfilesizepanel and rer.hardening | ||
| customizations. | ||
| """ | ||
|
|
||
| def __call__(self): | ||
| filedata = self.request.form.get("file", None) | ||
|
|
||
| if not filedata: | ||
| return super(FileUpload, self).__call__() | ||
|
|
||
| # limitfilesizepanel check | ||
| filename = filedata.filename | ||
| content_type = mimetypes.guess_type(filename)[0] or "" | ||
| ctr = api.portal.get_tool(name="content_type_registry") | ||
| portal_type = ctr.findTypeName(filename.lower(), content_type, "") or "File" | ||
|
|
||
| helper_view = api.content.get_view( | ||
| name="lfsp_helpers_view", | ||
| context=self.context, | ||
| request=self.context.REQUEST, | ||
| ) | ||
|
|
||
| if helper_view.newDataOnly() and "/edit" in self.request.get( | ||
| "HTTP_REFERER" | ||
| ): # noqa | ||
| return super(FileUpload, self).__call__() | ||
| maxsize = helper_view.get_maxsize_tiny((portal_type,)) | ||
| if not maxsize: | ||
| return super(FileUpload, self).__call__() | ||
|
|
||
| size_check = helper_view.check_size(maxsize=maxsize, uploadfile=filedata) | ||
| if size_check and not size_check.get("valid", False): | ||
| response = self.request.RESPONSE | ||
| response.setStatus(403) | ||
| return size_check.get("error", "") | ||
|
|
||
| return super(FileUpload, self).__call__() | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@folix-01 l'header REFERER non è garantito che i browser lo passano durante le richieste, se anche la pagina precendete era /edit ma il browser non ti passa il REFERER, il funzionamento normale è comunque garantito?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tutto questo è copiato da rer.base, facendo le prove, funziona