ported to ts and added logs #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look over it as soon as I can, thank you for your help! |
RedCrafter07
approved these changes
Aug 9, 2023
RedCrafter07
requested changes
Aug 9, 2023
There was a problem hiding this comment.
As the pm2 web dashboard was running over JavaScript before, it's still using "node ." for startup. I think it'll be a good idea if you add a startup script to complete your TypeScript Port, with tools like tsx.
I also noticed you haven't installed the types for node. Simply run pnpm i @types/node and you should be ready to go, otherwise tools like fs don't work. (Yes, you can remove the fs package, it isn't functional, it's just there so no one else registers fs because node has it implemented)
Otherwise, great job! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.