Fix Projection::invert on orthogonal projections and others. #24
Conversation
core/math/projection.cpp
Outdated
| #define SWAP_ROWS(a, b) \ | ||
| { \ | ||
| real_t *_tmp = a; \ | ||
| (a) = (b); \ | ||
| (b) = _tmp; \ | ||
| } |
There was a problem hiding this comment.
Why not just use https://en.cppreference.com/w/cpp/algorithm/swap ?
There was a problem hiding this comment.
Godot intentionally avoids using the STL
There was a problem hiding this comment.
In that case Godot/Redot should probably provide an alternative, macro uses like that are entirely unnecessary in C++.
There was a problem hiding this comment.
Godot intentionally avoids using the STL
I can't find a reference to the reasoning for this, do you know it?
There was a problem hiding this comment.
Godot intentionally avoids using the STL
I can't find a reference to the reasoning for this, do you know it?
Here. https://docs.godotengine.org/en/stable/contributing/development/cpp_usage_guidelines.html
The document states that STL is not allowed.
There was a problem hiding this comment.
It would be nice if it were possible to implement Abseil so that Godot/Redot wouldn't need to manually implement custom types. For example, instead of using Godot's custom String type versus STL's String type, they could use Abseil with Unicode support and achieve smaller binary sizes compared to using STL.
Fixes godotengine#68878, specially when using orthographic projection. Also adds some tests.
EIREXE
force-pushed
the
inverted_composer
branch
from
3aa46b9 to
3efcb0c
Compare
|
Could you link the implementation from which this was pulled? |
Related to godotengine/godot#68878, specially when using orthographic projection.
Replaces our invert implementation with mesa's, which seems to work fine.