Address Websocket Dropping Messages #697
Closed
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadenTheFolf
force-pushed
the
websocket-rework
branch
from
9357156 to
cb4aaa2
Compare
RadenTheFolf
force-pushed
the
websocket-rework
branch
from
cb4aaa2 to
0eea786
Compare
…pt them if they fit in in_buffer
RadenTheFolf
force-pushed
the
websocket-rework
branch
from
0eea786 to
bd58183
Compare
SkogiB
approved these changes
Oct 14, 2024
|
Leaving open but this fix is waiting to see if godotengine/godot#98167 will be merged. |
|
all files here has "GODOT ENGINE" on his header comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed wsl_peer to grab the length of incoming messages and only accept them if they fit in in_buffer