Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Fix ColorPicker overbright indicator position #803

Conversation

Spartan322
Copy link
Member

(cherry picked from commit blazium-engine/blazium@f7c6762)

@Spartan322 Spartan322 added bug topic:gui cherrypick:master Considered for cherry-picking into a master labels Oct 25, 2024
@Spartan322 Spartan322 changed the title Fix ColorPicker overbright indicator position [4.3] Fix ColorPicker overbright indicator position Oct 25, 2024
@Spartan322 Spartan322 merged commit 2ed9883 into Redot-Engine:4.3 Oct 25, 2024
18 checks passed
@Spartan322 Spartan322 deleted the 4.3-fix/colorpicker-overbright-indicator branch October 25, 2024 06:35
@Captain-Wet-Beard
Copy link

Verified on Github
image

@Spartan322
Copy link
Member Author

@Captain-Wet-Beard How about you read https://github.com/godotengine/godot/blob/master/AUTHORS.md and https://github.com/Redot-Engine/redot-engine/blob/master/REDOT_AUTHORS.md first, its pretty explicitly clear that neither represent copyright, and the license is still MIT, only the git blame is covered under copyright and he is credited.

@Captain-Wet-Beard
Copy link

the license is still MIT

Since your PR admits youre cherrypicking Blazium PRs, are you planning to add a line to your copy of the MIT license for Blazium contributors?

@Spartan322
Copy link
Member Author

Spartan322 commented Oct 26, 2024

No, first our LICENSE.txt will not change, secondly it there was no copyright for blazium when the commit was made, even in future cherry-picks its not actually required if the commit makes proper reference to the repo at the time it was cherry-picked which it does regardless. If community people really cared about it, the segments can be commented with the license/repo reference, but that's already fairly excessive anyway. And any modifications done by Redot contributors that overrides the hunks would immediately remove the license anyway.

@LokiFawkes
Copy link

Whales is in the AUTHORS.md file, so clearly author credit is not the issue. Seems like Blazium just wants attention.

@Captain-Wet-Beard
Copy link

Whales is in the AUTHORS.md file, so clearly author credit is not the issue.

I must have missed where AUTHORS.md is mentioned in the wording of the MIT license.

I was just pointing out a potential copyright problem out of friendly concern, it really doesn't effect me one way or the other if you choose to play fast and loose with licenses.

Feel free to interpret my good faith concern in any way you wish, like I said it isnt my problem.

@Redot-Engine Redot-Engine locked and limited conversation to collaborators Oct 27, 2024
@tindrew tindrew added this to the 4.3 milestone Oct 29, 2024
@Spartan322 Spartan322 removed the cherrypick:master Considered for cherry-picking into a master label Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants