-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.3] Fix ColorPicker
overbright indicator position
#803
[4.3] Fix ColorPicker
overbright indicator position
#803
Conversation
(cherry picked from commit blazium-engine/blazium@f7c6762) Co-authored-by: Mounir Tohami <[email protected]>
ColorPicker
overbright indicator positionColorPicker
overbright indicator position
@Captain-Wet-Beard How about you read https://github.com/godotengine/godot/blob/master/AUTHORS.md and https://github.com/Redot-Engine/redot-engine/blob/master/REDOT_AUTHORS.md first, its pretty explicitly clear that neither represent copyright, and the license is still MIT, only the git blame is covered under copyright and he is credited. |
Since your PR admits youre cherrypicking Blazium PRs, are you planning to add a line to your copy of the MIT license for Blazium contributors? |
No, first our LICENSE.txt will not change, secondly it there was no copyright for blazium when the commit was made, even in future cherry-picks its not actually required if the commit makes proper reference to the repo at the time it was cherry-picked which it does regardless. If community people really cared about it, the segments can be commented with the license/repo reference, but that's already fairly excessive anyway. And any modifications done by Redot contributors that overrides the hunks would immediately remove the license anyway. |
Whales is in the AUTHORS.md file, so clearly author credit is not the issue. Seems like Blazium just wants attention. |
I must have missed where AUTHORS.md is mentioned in the wording of the MIT license. I was just pointing out a potential copyright problem out of friendly concern, it really doesn't effect me one way or the other if you choose to play fast and loose with licenses. Feel free to interpret my good faith concern in any way you wish, like I said it isnt my problem. |
(cherry picked from commit blazium-engine/blazium@f7c6762)