Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the Web-Editor build and styles #880

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optimize the Web-Editor build and styles #880

wants to merge 2 commits into from
+392 −373

Conversation

MarekZeman91
Copy link

BEFORE

Old Intro Old Editor

AFTER

New Intro New Editor

Main changes

  • colors and naming changes to reflect the rebranding
  • JavaScript in editor.html optimized
  • CSS from editor.html moved to styles.css
  • tabs are aligned to the right and have active state
  • fixed JavaScript errors for missing variables
  • removed JavaScript infinite focus loop

IMPORTANT BUILD INFO

The web build works with UP TO emsdk 3.1.67.

Here is my Makefile:

build:
	../emsdk/emsdk install 3.1.67 && ../emsdk/emsdk activate 3.1.67 && source ../emsdk/emsdk_env.sh && scons platform=web target=editor

serve:
	python3 platform/web/serve.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Norrox Norrox Norrox approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement needs testing performance platform:web rebranding issues and pr's related to engine rebranding topic:editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarekZeman91 @Norrox @Spartan322