Store reverse geo-coded address & force unique addresses #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeDeeG
added
enhancement
Ready for Review
Hacktoberfest
cllns
reviewed
Nov 11, 2018
|
|
||
| puts "" | ||
|
|
||
| Restroom.all.each do |restroom| |
There was a problem hiding this comment.
Do we want to do this for all Restrooms, or can we just do ones that have some columns missing?
There was a problem hiding this comment.
Depends if you're particularly fussy about the display, for example casing and Street vs St.
added 2 commits
November 12, 2018 21:00
|
Merging into a refuge/ branch so I can fix the test |
|
By the way, when I looked at this, it made the I'm not fluent with Ruby enough to get why, although I can tell a lot is changed around in the same file that #513 touched, so it makes sense. (Not sure how important that is, probably not enough to block this new feature, but if I can help make it work again, would be happy to.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Generally, this makes the data more consistent, however this relies more on the geocode lookup being correct for what the user puts in. It might be a good idea to force the user to preview (via google maps) before they can submit a restroom, or to use a proper address lookup. Thoughts?
Summary of Changes
Restrooms will now populate the geocode, then set the address fields to the address from a reverse lookup before validation.
The address field must be unique. This is only enforced in the activerecord model & not the database schema, meaning it won't complain about existing records / manually added records.
Added a task that iterates over each restroom and re-populates the address from a reverse geocode lookup (
db:reverse_geocode/db:reverse_geocode[dry_run])