Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first try at having scrubing on other database. Not fully implemented… #45

Conversation

farialima
Copy link

… yet, tests not passing... so really not ready for merging !!

but it could give you an idea of how to make it work cleanly ?

@farialima
Copy link
Author

I suspect that what's missing is simply handling relationships within objects...

@farialima farialima marked this pull request as draft July 11, 2022 17:30
@lociii
Copy link
Member

lociii commented Jul 12, 2022

I'm not sure if your scenario of having complete secondary databases will match the use case of most other users.
I would assume that most will have just some models on other databases. This setup of expecting sessions and all app models on the secondaries would break for them.

@farialima
Copy link
Author

farialima commented Jul 12, 2022

I'm not sure if your scenario of having complete secondary databases will match the use case of most other users.
I would assume that most will have just some models on other databases. This setup of expecting sessions and all app models on the secondaries would break for them.

Good point.... TBH, I mostly wrote the code in this PR as a base for someone (anyone :) ) else starting working on this... My added value here is mostly set up the tests on multiple databases, I happened to have experience on this, it can help... but really I don't have the time to dive in the Django-scrubber code -- knowing that I've suggested an (true, ugly, but working) workaround in the #35 ticket

@lociii
Copy link
Member

lociii commented Aug 20, 2024

I'll close this for now as there seems to be no further interest by other users in this solution.
Thanks for the contribution anyways.

@lociii lociii closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants