-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add new UI #313
Merged
[ENH] add new UI #313
Changes from 25 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
c2f95a6
refactor and deal with simple visbility
Remi-Gau 69a273a
add protocol page
Remi-Gau c6920d2
display activity in protocol page
Remi-Gau db86e44
fix issue new instance form
Remi-Gau 1371a63
fix path activity
Remi-Gau 3a477c7
style items and deal with sliders items
Remi-Gau a87de83
add min and max value for int and float
Remi-Gau 4337acc
add min max to float and refactor ui
Remi-Gau cf5c94c
refactor
Remi-Gau 1c98007
basic upload
Remi-Gau 569c710
enable upload
Remi-Gau 4beb48d
refactor
Remi-Gau 79af006
package
Remi-Gau f273fa4
reorganize items description and details
Remi-Gau a06b4e4
update details items
Remi-Gau 4e2346d
update visbility handling
Remi-Gau 91e0a21
upload bold json
Remi-Gau af5f34b
adapt size
Remi-Gau 0f4df82
refactor ui
Remi-Gau b51104f
refactor tests
Remi-Gau 3519a09
refactor
Remi-Gau 07d6ba3
generate and download methods
Remi-Gau c399b81
reformat jinja templates
Remi-Gau a9f7a5a
add section about preprocessing
Remi-Gau 4bb563f
refactor
Remi-Gau 31eb4dd
move ui into new repo
Remi-Gau 4fc2719
update precommit
Remi-Gau f1440a5
Merge remote-tracking branch 'origin/main' into ui
Remi-Gau 0184233
update all schemas
Remi-Gau 312e831
update precommit
Remi-Gau 0041650
drop reproschema-ui
Remi-Gau e279d5d
fix tests
Remi-Gau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,8 @@ | ||
{ | ||
"recommendations": [ | ||
"ms-python.python", | ||
"sourcery.sourcery", | ||
"ms-python.vscode-pylance" | ||
], | ||
"unwantedRecommendations": [ | ||
] | ||
"recommendations": [ | ||
"ms-python.python", | ||
"sourcery.sourcery", | ||
"ms-python.vscode-pylance" | ||
], | ||
"unwantedRecommendations": [] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"restructuredtext.pythonRecommendation.disabled": true | ||
"restructuredtext.pythonRecommendation.disabled": true | ||
} |
Submodule cobidas_schema
updated
787 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (complexity): Consider simplifying the new validation logic for
visibility
values.The new code introduces additional complexity that may not be necessary. Here are some points to consider:
Introduction of
ast
Module: The new code introduces theast
module and a new functionis_valid_python
. While this might be necessary for specific validation, it adds additional complexity. The original code did not require this module, and its introduction should be justified with a clear need.New Validation Logic: The new validation logic for
visibility
values adds a loop and a function call that were not present in the original code. This increases the cognitive load for anyone reading or maintaining the code.Error Handling: The new
is_valid_python
function includes error handling forSyntaxError
andValueError
, which adds more branches and potential points of failure in the code.Logging: The new code adds additional logging for invalid
visibility
values. While logging is generally good for debugging, it adds more lines of code and complexity.Code Structure: The new code introduces a new function
is_valid_python
and modifies themain
function. This changes the structure of the code, making it less straightforward than the original.Consider simplifying the code to maintain readability and ease of maintenance. Here is a less complex way to achieve the same functionality:
This refactored version reduces complexity by keeping the
is_valid_python
function simple and focused, using list comprehensions to simplify the validation logic, and ensuring that the main structure of the code remains clear and easy to follow.