This repository has been archived by the owner on Jul 25, 2023. It is now read-only.
Proxy shim for simplifying development environment workflow #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sporkmonger
reviewed
Jan 3, 2019
sporkmonger
suggested changes
Jan 3, 2019
|
|
||
| opts := devproxy.NewOptions() | ||
|
|
||
| err := envconfig.Process("", opts) |
There was a problem hiding this comment.
I think this is the right choice, to use environment variables for config. It's probably more common to use the flag package, but having a parallel structure to what's already there probably makes more sense.
sporkmonger
reviewed
Jan 14, 2019
internal/devproxy/dev_config.go
Outdated
|
|
||
| // SkipAuthCompiledRegex []*regexp.Regexp | ||
| // AllowedGroups []string | ||
| Route interface{} // note: :/ |
malizz
commented
Jan 14, 2019
malizz
commented
Jan 14, 2019
malizz
commented
Jan 14, 2019
malizz
commented
Jan 14, 2019
sporkmonger
force-pushed
the
production
branch
from
1613a14 to
55f1d27
Compare
sporkmonger
force-pushed
the
production
branch
from
f65acc0 to
6ceebb1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A production deployment does not allow failing verification, test permissions (that may not necessarily exist for them in prod).
Solution
Simplifying development environment workflow by replacing the production proxy with a shim that reads its settings from a config file.