Fixed issues with Swiss Francs #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ToString/Parse round-trip failed because of '.' in "fr." (and possibly other currencies with a '.' in their symbol) - replaced unused/outdated symbol "fr." by "CHF" - added NodaMoney.CurrencySymbolParser, provided unit tests - added NodaMoney.Tests.Helpers.CultureNames with constants used by several unit tests - added NodaMoney.Currency.GetCurrencies(string symbol) with a cached lookup - modified NodaMoney.CurrencyRegistry - made static fields into instance fields - introduced helper method GetKey - removes namespace when empty - maintains a lookup for currency resolution by symbol - added GetCurrencies(string symbol) - reworked NodaMoney.Money.ExtractCurrencyFromString - replaced insufficient IsNotNumericCharacter by CurrencySymbolParser.Parse - replaced inefficient Currency.GetAllCurrencies().Where(...) by Currency.GetCurrencies(symbol) and Currency.Registry.TryGet(code) - added NodaMoney.Tests.MoneyFormattableSpec.GivenIWantMoneyAsString._swissFranc and corresponding unit tests - added NodaMoney.Tests.MoneyFormattableSpec.GivenIWantMoneyAsStringWithCurrencySymbol._swissFranc and corresponding unit tests - added NodaMoney.Tests.MoneyFormattableSpec.GivenIWantMoneyAsStringWithCurrencyCode._swissFranc and corresponding unit tests - added NodaMoney.Tests.MoneyFormattableSpec.GivenIWantMoneyAsStringWithEnglishCurrencyName._swissFranc and corresponding unit tests - modified unit tests in NodaMoney.Tests.MoneyParsableSpec - unified naming and setup - added unit tests related to Swiss Francs
RemyDuijkeren
added a commit
that referenced
this pull request
Feb 16, 2025
Cherry pick from Pull Request #96. ToString/Parse round-trip failed because of '.' in "fr." (and possibly other currencies with a '.' in their symbol), replaced unused/outdated symbol "fr." by "CHF", added unit tests related to Swiss Francs, new parsing symbol from string
|
Cherry picked Pull Request into e9ea404 Sorry for the long delay. Nice findings and solutions. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToString/Parse round-trip failed because of '.' in "fr." (and possibly other currencies with a '.' in their symbol)
replaced unused/outdated symbol "fr." by "CHF"
added NodaMoney.CurrencySymbolParser, provided unit tests
added NodaMoney.Tests.Helpers.CultureNames with constants used by several unit tests
added NodaMoney.Currency.GetCurrencies(string symbol) with a cached lookup
modified NodaMoney.CurrencyRegistry
reworked NodaMoney.Money.ExtractCurrencyFromString
added NodaMoney.Tests.MoneyFormattableSpec.GivenIWantMoneyAsString._swissFranc and corresponding unit tests
added NodaMoney.Tests.MoneyFormattableSpec.GivenIWantMoneyAsStringWithCurrencySymbol._swissFranc and corresponding unit tests
added NodaMoney.Tests.MoneyFormattableSpec.GivenIWantMoneyAsStringWithCurrencyCode._swissFranc and corresponding unit tests
added NodaMoney.Tests.MoneyFormattableSpec.GivenIWantMoneyAsStringWithEnglishCurrencyName._swissFranc and corresponding unit tests
modified unit tests in NodaMoney.Tests.MoneyParsableSpec