Merge master of upstream to Repairshopr #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In df60a2c when execute_threeds is false it is assigned to the additionalData as a whole instead of additively, so previously added additionalData fields were destroyed. This change adds the field safely. Remote: 92 tests, 353 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 70 tests, 330 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#2756
Fixes the RuboCop to-do for [Layout/SpaceAroundEqualsInParameterDefault](https://docs.rubocop.org/rubocop/0.85/cops_layout.html#layoutspacearoundequalsinparameterdefault). All unit tests: 4543 tests, 72248 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Give ability to pass customer details outside of the scope of the billing address CE-795 Unit: 18 tests, 178 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 14 tests, 61 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Add unit test
When attempting certain apple pay transactions, the following error occurs: ``` Error. The Orbital Gateway has received a badly formatted message. Field [Verified-By-Visa XID] exceeded max length of [40] ``` This is technically because in practice, the creditcard.transaction_id on these network tokens is (sometimes? always?) longer than 40 characters, and we aren't trimming it down in any way. However, after looking at the docs, it does not appear that XID is actually a required field for transactions made with network tokens - instead, the main field of note is `DigitalTokenCryptogram`. From docs: ``` An additional cryptogram field (digitalTokenCrytogram) has been added which is compatible with all card brand specific cryptograms. This field must also be submitted as Base 64 encoded. The gateway will parse the data and populate the appropriate fields in the request host message. ``` Orbital suppport mentioned the following about this field when asked about this error: ``` In Orbital, the DigitalTokenCryptogram replaces the other fields necessary for the cryptogram. So it's an either-or situation. I believe XID is specifically the American Express cryptogram field. ``` Additionally, in the initial implementation we believed this field was not required, but decided to send it just in case it might be needed (activemerchant#2553 (comment)). Given the results currently observed, this PR removes XID unless the transaction is a 3DS visa transaction. Remote: 37 tests, 188 assertions, 4 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 89.1892% passed (failures also happening on master) Unit: 95 tests, 560 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Add support for service fee which can be passed in the request body as `service_fee_amount`. To note, merchants must be configured to accept service/convenience fees or they will get a 'U27: CONV FEE NOT ALLOWED' [transaction response code](https://www.forte.net/devdocs/reference/response_codes.htm). The sandbox environment I am working with is not configured for service fees so I was unable to write a remote test for this. CE-491 Unit: 21 tests, 72 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 22 tests, 63 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed - Create specific response for successful_purchase_with_service_fee - Update CHANGELOG
Add the ability to send through an Idempotency-Key as a header on Worldpay transactions as an option. Unit tests: 75 tests, 491 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote tests: Finished in 78.308251 seconds. 57 tests, 239 assertions, 5 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.2281% passed The tests (which are also failing on master): test_3ds_version_1_parameters_pass_thru test_3ds_version_2_parameters_pass_thru test_successful_credit_using_token test_successful_mastercard_credit_on_cft_gateway test_successful_visa_credit_on_cft_gateway
`if :line_tot` is not resolving to true in some cases because the value is actually a string. Expanding the check to evaluate against a string and symlink should resolve this issue. CE-762 Unit: 95 tests, 560 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 37 tests, 192 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.5946% passed
Fixes the RuboCop to-do for [Lint/UnusedMethodArgument](https://docs.rubocop.org/rubocop/0.85/cops_lint.html#lintunusedmethodargument). All unit tests: 4543 tests, 72248 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Fixes the RuboCop to-do for [Naming/MemoizedInstanceVariableName](https://docs.rubocop.org/rubocop/0.85/cops_naming.html#namingmemoizedinstancevariablename). All unit tests: 4543 tests, 72248 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Fixes the RuboCop to-do for [Style/BlockComments](https://docs.rubocop.org/rubocop/0.85/cops_style.html#styleblockcomments). All unit tests: 4544 tests, 72251 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
When the Checkout V2 adapter was initially implemented, it seems that the Checkout API couldn't perform a refund on an auto-captured authorizations (ie, single-transaction purchase), so Purchase used a multi-response authorization and capture call. We have recently noticed intermittent Purchases that the adapter considers successful but in fact the Capture response was a 404. According to Checkout, this may be due to their id for the authorization not having yet been instantiated before the Capture reached them. So the multiresponse is too fast for its own good, and also the adapter's success criteria isn't sufficient to catch a failed Capture as part of a Purchase. However, it seems that the constraint on refunds has since been removed. So, we can switch to a single-transaction Purchase, by not setting the capture field as false. There should be no effective difference in terms of the resulting Response. Remote: 33 tests, 80 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 29 tests, 129 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Fixes the RuboCop to-do for [Naming/ConstantName](https://docs.rubocop.org/rubocop/0.85/cops_naming.html#namingconstantname). All unit tests: 4543 tests, 72248 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
After fixing an issue with problematic values being sent for network tokenized PMs, errors relating to the request not adhering to the DTD would sometimes appear. This happens in the existing code when soft descriptors are passed along with a network tokenized card. In the schema, the soft descriptor fields need to come before the network token fields. This PR updates the order of these elements and adds additional test conditions. Unit: 96 tests, 563 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 37 tests, 192 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.5946% passed (same as master)
The Checkout sandbox API supports invocation of response types via specific amounts: https://docs.checkout.com/testing/response-code-testing We're currently testing failed cases via a bad card number, but this actually invokes fails-by-error rather than proper decline/invalid number responses. This changes the primary authorize and purchase remote tests to utilize this method, but is only a start. Remote: 33 tests, 81 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
When all `mdd_field` options are `nil`, the merchantDefinedData gets added as an empty XML tag which causes the gateway to return a parse error. 4559 tests, 72371 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Fixes the RuboCop to-do for [Naming/VariableNumber](https://docs.rubocop.org/rubocop/0.85/cops_naming.html#namingvariablenumber). PayPal remote tests: 29 tests, 81 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed All unit tests: 4544 tests, 72251 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
* Update Moneris test credentials
Based on a conversation with Moneris and some failed test transactions, updating the test credentials to use `store5` instead of `store1`.
* $0 Auth on Checkout gateway
CE-590
REMOTE
Loaded suite test/remote/gateways/remote_checkout_v2_test
Started
.................................
Finished in 36.85309 seconds.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
33 tests, 80 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
0.90 tests/s, 2.17 assertions/s
UNIT
Loaded suite test/unit/gateways/checkout_v2_test
Started
.............................
Finished in 0.009335 seconds.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
29 tests, 130 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
3106.59 tests/s, 13926.08 assertions/s
* Added spaces in options = {} for rubocop
* Update .gitignore
Added a new line after final line
* Update remote_checkout_v2_test.rb
Adding a check to ensure that checkout_v2 is not calling void
* Checkout V2: update unit tests
* Update .gitignore
Remove .idea from the .gitignore
* Update CHANGELOG
Co-authored-by: Leila Alderman <[email protected]>
Co-authored-by: Ruthan <[email protected]>
Adds more BIN numbers to the Elo card type. No remote tests since this is for credit card methods Unit tests: --------------------------------------------------------------------------------------------------------- 4562 tests, 72383 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed --------------------------------------------------------------------------------------------------------- 143.23 tests/s, 2272.50 assertions/s
* Update paybox_direct.rb Adding 3DS features to the integration * Update paybox_direct.rb adapting to feedback * Paybox: update fixtures * Paybox: fix unit tests * Paybox: update remote test to use cards from fixtures * Paybox: update remote test to add 3DS info only if 3DS is enabled * Paybox: fix remote test (without 3DS) * Paybox: fix add_3dsecure method * Paybox: add remote tests for 3DS * Fix Ruby style * - Fix `three_d_secure` options format * - Remove trailing comma Co-authored-by: Vincent HADJEDJ <[email protected]>
CardIndicators field is being sent, but not received by the Orbital gateway. In the schema, the line items field needs to come before the card indicators field, but they are switched. This PR updates the order of those elements and adds additional testing. CE-710 UNIT: 96 tests, 563 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed REMOTE: 38 tests, 195 assertions, 4 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 89.4737% passed (Same as master) Update CHANGELOG
Pass in subMerchant fields for reconciliation Also update `apple_pay` and `google_pay` test cards CE-985 Unit: 70 tests, 336 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passedt Remote: 92 tests, 353 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Use postal_code instead of zip and subMerchantMCC
Similar to commit e99842b For reference transactions, PayPal Express does not require payment_type, invoice_id, description or ip. We shouldn't require them either. They can be optionally passed in, but are not required. This change removes the requirement from reference based authorizations. PayPal remote tests 29 tests, 81 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed PayPal Express remote tests 3 tests, 8 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed All unit tests 4563 tests, 72384 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Added support for partial refunds indicated by passing `partial_refund: true` in the options hash. Previously, all refunds were treated as full refunds, regardless of the amount sent to the gateway. ECS-1401 Unit: 34 tests, 137 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 35 tests, 79 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.4286% passed All unit tests: 4563 tests, 72389 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Fixes the RuboCop to-do for [Style/Alias](https://docs.rubocop.org/rubocop/0.85/cops_style.html#stylealias). All unit tests: 4544 tests, 72251 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
…ctivemerchant#3776) CE-1051 Co-authored-by: Ruthan <[email protected]>
Fixes the RuboCop to-do for [Performance/RedundantMatch](https://docs.rubocop.org/rubocop-performance/cops_performance.html#performanceredundantmatch). All unit tests: 4561 tests, 72379 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Fixes the RuboCop to-do for [Layout/MultilineMethodCallBraceLayout](https://docs.rubocop.org/rubocop/0.85/cops_layout.html#layoutmultilinemethodcallbracelayout). All unit tests: 4561 tests, 72379 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Add standardized 3DS fields to the NMI gateway per the documented convention that active_merchant has adopted. Active Merchant documentation related to 3DS can be found on the [Standardized 3DS Fields wiki](https://github.com/activemerchant/active_merchant/wiki/Standardized-3DS-Fields). Resolve transaction variable names to match [NMI's integration documentation](https://secure.networkmerchants.com/gw/merchants/resources/integration/integration_portal.php#transaction_variables). CE-869 Unit: 46 tests, 352 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 42 tests, 156 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Update CHANGELOG
Add ability to send through SubMerchant object which enables the sending of information from sub-accredited. CE-1027 Update add_submerchant method to match case of gateway's expectations. Revised tests to include assert_match for additional fields being sent in the request. Unit 29 tests, 146 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote 39 tests, 96 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Revise add_submerchant method so that the gateway is being passed case sensitive requests, but Active Merchant is being passed snake_case to remain consistent with formatting. Update CHANGELOG
Corrects the mapping of phone numbers from `shipping_address` object. CE-1665 Rubocop: 702 files inspected, no offenses detected Unit: 4760 tests, 73628 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 35 tests, 83 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 94.2857% passed
CE-1638 Include the challengePreference paramater in 3ds requests sent to Nuvei Unit: 24 tests, 132 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote(2 unrelated failures): 28 tests, 74 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 92.8571% passed
Pass networkTxReference in additionalData hash for all relevant transactions. This value should be passed with stored credential fields used in MIT. CE-1603 Unit: 76 tests, 397 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 100 tests, 385 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
CE-1543 Rubocop 705 files inspected, no offenses detected Unit 4776 tests, 73694 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote Loaded suite test/remote/gateways/remote_adyen_test 101 tests, 390 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
PayTrace supports the addition of level_3_data to any approved and unsettled sale transaction. In order to add level_3_data to an approved transaction, the transaction will have to have been completed and returned a transaction_id. Due to this workflow, the method to add level_3_data has been built into the end of the purchase method. As of now, only Visa and MasterCard are supported for level_3_data so an additional test has been included in the remote file to make sure that if a card other than visa or MasterCard is processed, the purchase will go through and the attempt to add level_3_data will be ignored. CE-1737 Local: 4775 tests, 73690 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 18 tests, 70 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 24 tests, 58 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
CE-1669 Rubocop: 705 files inspected, no offenses detected Unit: 4779 tests, 73706 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: Loaded suite test/remote/gateways/remote_blue_pay_test 18 tests, 89 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Loaded suite test/unit/gateways/orbital_test 122 tests, 716 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Loaded suite test/remote/gateways/remote_orbital_test 69 tests, 320 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed bundle exec rake test:local 4778 tests, 73709 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Running RuboCop... 705 files inspected, no offenses detected
Allow sending the transaction_source as recurring_first or moto. Also exposes the `recurring` param on responses. https://developer.paypal.com/braintree/docs/reference/request/transaction/sale#transaction_source Remote: 86 tests, 455 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 85 tests, 192 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Add option to pass `include_capture_amount` field to trigger the sending of specified amount. Without this option set to true, the capture method will act on whatever dollar amount the original authorization included. Local: 4784 tests, 73748 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 19 tests, 74 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 25 tests, 64 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Added DuplicateOverrideFlag gateway specific field to the Vantive Express(formely Element) gateway along with unit and remote tests. CE-474 Unit: 23 tests, 118 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 25 tests, 75 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Closes activemerchant#4012
- Docs do not reflect that custom eci option is possible - Wrote remote test to confirm that add_eci method works BarclaysEpdqExtraPlus: updated messages on some remote tests Local: Finished in 9.822681 seconds. ----------------------------------------------------------------------------------------------------------------------------- 4787 tests, 73769 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ----------------------------------------------------------------------------------------------------------------------------- 487.34 tests/s, 7510.07 assertions/s Running RuboCop... Inspecting 705 files Unit: Finished in 0.067872 seconds. ----------------------------------------------------------------------------------------------------------------------------- 44 tests, 185 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed ----------------------------------------------------------------------------------------------------------------------------- 648.28 tests/s, 2725.72 assertions/s Remote (failures on master as well): Finished in 37.770573 seconds. ----------------------------------------------------------------------------------------------------------------------------- 19 tests, 73 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 84.2105% passed ----------------------------------------------------------------------------------------------------------------------------- 0.50 tests/s, 1.93 assertions/s
CE-1716 Remote Tests: 98 tests, 502 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.8776% passed The following six failed remote tests also failed on master branch: test_successful_3ds_validate_authorize_request test_successful_3ds_validate_purchase_request test_successful_authorization_and_failed_capture test_successful_pinless_debit_card_purchase test_successful_tax_calculation test_successful_validate_pinless_debit_card Local Tests: 4777 tests, 73697 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed RuboCop: 705 files inspected, no offenses detected Unit Tests: 106 tests, 512 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Added more options to the payer object if they are present, added Metadata object if present. Checking for exact external_reference field as a second option when setting CE-843 Unit: 39 tests, 181 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: The failed tests here are also failing for me on the master branch. 35 tests, 100 assertions, 3 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 91.4286% passed Closes activemerchant#4020
The gateway uses the pin and other data to create a SHA hash to authenticate transactions for accounts where pin is enabled. So now if pin is set when creating the gatway it will pass it into the hash if not it will be ignored like it has been. CE-1743 unit: 50 tests, 303 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed remote: 32 tests, 114 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 96.875% passed <= the failed test is the scrubbed test, and it foils because the response from the gateway includes UMrefNum field which happens to have in the log number the same 3 digit verification_value as the test card. Closes activemerchant#4026
Add support for incremental auth (adjust) transactions. In scenarios where a merchant authorizes payment but needs to make an adjustment to that auth before capture, they make an adjust request. Currently, a merchant would have to execute a void and a new auth before capture. Fixtures placeholder for CS MID with LATAM procesors Add testing for adjust transaction CE-1438 Unit: 102 tests, 499 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 96 tests, 500 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 93.75% passed
Add more Canadian banks to the list of valid institution numbers CE-1754 Unit: 10 tests, 22 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: None
EVS-874 Unit: 86 tests, 533 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote (2 pre-existing failures): 68 tests, 292 assertions, 2 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 97.0588% passed
… scenarios - Adjust refund method to include money argument - Revise message_from method to include error message details and handle multiple errors - Revise authorization_from to support returning a third_party_token for store - Revise necessary tests Local: 4787 tests, 73769 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 19 tests, 74 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 27 tests, 68 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
CE-1704 Local: 4792 tests, 73784 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 49 tests, 244 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 38 tests, 169 assertions, 8 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 78.9474% passed
It is not sufficient to look at ProcStatus 0=Success for setting refunds as successful. Additional response parameter that needs to be checked is ApprovalStatus that can have the following values: 0=Declined 1=Approved 2=Message/System Error. If it was not approved RespCode will indicate the reason. ECS-1881 Unit: 125 tests, 726 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 70 tests, 323 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Remove support for `include_capture_amount` field, it is not needed for partial captures to succeed CE-1777 Local: 4795 tests, 73802 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Unit: 17 tests, 67 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed Remote: 27 tests, 69 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications 100% passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled changes from upstream to merge to our fork