Upstream Rails 5 no conflicts #4
Conversation
Remove uuid gem in favor of SecureRandom
[Gems]/ruby-saml-idp-0.3.2/lib/saml_idp/controller.rb:54:in `inflate' [Gems]/ruby-saml-idp-0.3.2/lib/saml_idp/controller.rb:54:in `decode_SAMLRequest' [Gems]/ruby-saml-idp-0.3.2/lib/saml_idp/controller.rb:49:in `validate_saml_request'
TheInResponseTo is optional. If it's not specified we should not render it because it will fail schema validation.
I noticed this was missing while running an automated licensing audit for a project I'm working on that may use this gem.
Add optional session expiration information
The Controller makes reference to SecureRandom.uuid but the library is never imported.
Require 'securerandom' library
There was a problem hiding this comment.
This looks fine.
I was intending for https://github.com/RepairShopr/domo-auth/pull/7 to update domo-auth to use a Gemfile reference to a new branch on RepairShopr/ruby-saml-idp so that the fork could maintain parity with upstream without complicated merges on master branch
I did not intend https://github.com/RepairShopr/ruby-saml-idp/pull/3/files?diff=unified&w=1 to be merged into this branch, and was instead hoping to reset the master branch.
All that said, it's probably not worth working on the git branch management on this repository right now.
Strictly speaking, we also do not need to merge this branch and update https://github.com/RepairShopr/domo-auth/pull/7 to point to master branch#head or the specific merge commit. it should be fine for domo-auth to point at whatever specific commit on this branch that works for us
No description provided.