Update schema #5
Conversation
|
this added the .venv directory |
Fixed @satra |
nimh_minimal/nimh_minimal_schema
Outdated
| @@ -2,7 +2,7 @@ | |||
| "@context": [ | |||
| "https://raw.githubusercontent.com/ReproNim/reproschema/1.0.0-rc4/contexts/generic", | |||
| { | |||
| "activity_path": "https://raw.githubusercontent.com/ReproNim/reproschema-library/80867e36fb2c00563290486bf3f3bbeb3198f5cb/activities/" | |||
| "activity_path": "https://raw.githubusercontent.com/ReproNim/reproschema-library/enh/rc4/activities/" | |||
There was a problem hiding this comment.
shall we switch this to a specific committish now, if this all works?
There was a problem hiding this comment.
I realized there is a test case on enh/rc4 in reproschema-library that wasn't passing--should be fixed when this is merged:
ReproNim/reproschema-library#80
I ran the test locally before pushing.
|
also can we update the github workflow checksum, so this protocol renders using the correct ui committish? |
Slightly confused by what you mean here. My conclusion from the conversation about the UI before is that the only way to render a protocol with a specific version of the UI is to host that version somewhere. Would you mind explaining a bit more? |
indeed and it would be hosted here in this repo. so updating the checksum in config.env should be all that's needed. |
|
But what should I update the checksum to? The latest checksum for the fix/static branch of reproschema-ui? |
|
i think that was already merged, so the current checksum should be fine. |
|
sorry it wasn't merged. so yes, you can take the committish of that branch and use it. |
Done @satra |
| @@ -2,7 +2,7 @@ | |||
| "@context": [ | |||
| "https://raw.githubusercontent.com/ReproNim/reproschema/1.0.0-rc4/contexts/generic", | |||
| { | |||
| "activity_path": "https://raw.githubusercontent.com/ReproNim/reproschema-library/80867e36fb2c00563290486bf3f3bbeb3198f5cb/activities/" | |||
| "activity_path": "https://raw.githubusercontent.com/ReproNim/reproschema-library/enh/rc4/a23a13875c7262c0bd0d77bd90c1ec296c6d1116/activities/" | |||
There was a problem hiding this comment.
i merged this, but i think this is incorrect. the branch name should not be there.
Updated with links to updated activities in:
https://raw.githubusercontent.com/ReproNim/reproschema-library/enh/rc4/activities/
The conditional logic of what activities are shown based on age conforms to:
https://nda.nih.gov/nda/nimh-common-data-elements
Demo:
https://ibevers.github.io/reproschema-ui/#/?url=https://raw.githubusercontent.com/ibevers/nimh-minimal/update_schema/nimh_minimal/nimh_minimal_schema