Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wrap 4 buttons #193

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Do not wrap 4 buttons #193

merged 2 commits into from
Jan 6, 2025

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Jan 6, 2025

Fixes #118

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for repronim ready!

Name Link
🔨 Latest commit 30c61b8
🔍 Latest deploy log https://app.netlify.com/sites/repronim/deploys/677c307cfbe6ad0008e3e97f
😎 Deploy Preview https://deploy-preview-193--repronim.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

At max size of the window, we will still have 4 to a row.
@asmacdo
Copy link
Member Author

asmacdo commented Jan 6, 2025

Still wraps for mobile, but I think that's ok.

image

@asmacdo
Copy link
Member Author

asmacdo commented Jan 6, 2025

There are still some widths that are a little awkward, but I've fiddled with it for a while now and not sure how to improve.

IMO it is most important that it looks ok on mobile (should be 2 per row) and at max width, with 4 per row.

@asmacdo
Copy link
Member Author

asmacdo commented Jan 6, 2025

@chaselgrove could you see how this renders for you? Feel free to merge if its good.

@chaselgrove
Copy link
Contributor

Thanks, @asmacdo; it now keeps the four across at greater widths. The two-and-two is completely appropriate for the mobile rendering.

@chaselgrove chaselgrove merged commit d508b45 into main Jan 6, 2025
6 checks passed
@asmacdo asmacdo deleted the fix-4-buttons branch January 9, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make front page buttons four across
2 participants