Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to version 1.0.0 #88

Merged
merged 5 commits into from
Jan 6, 2025
Merged

migrate to version 1.0.0 #88

merged 5 commits into from
Jan 6, 2025

Conversation

djarecka
Copy link
Member

@djarecka djarecka commented Nov 8, 2024

@yibeichan - could you please check if this look good to you (do not merge yet)

@djarecka
Copy link
Member Author

djarecka commented Nov 8, 2024

sorry, something is not right... will ping you again

@djarecka
Copy link
Member Author

djarecka commented Nov 8, 2024

@satra @yibeichan - right now the tests are failing since the migration is adding schemaVersion to responseOption, but I realized that this class do not have schemaVersion property (only Item, Protocol, Activityhave), and that was also the case for the previous version. I could just remove the property from theresponseOprions`, but perhaps we should add it in the next versions of the schema?

@satra
Copy link
Contributor

satra commented Nov 8, 2024

why do we need schemaVersion for that specific class? let's keep schemaVersion only for the top level classes (Protocol, Activity, Item).

@djarecka
Copy link
Member Author

djarecka commented Nov 8, 2024

why do we need schemaVersion for that specific class? let's keep schemaVersion only for the top level classes (Protocol, Activity, Item).

oh, I thought that maybe we should, but if not, I will just remove it from my code

@satra
Copy link
Contributor

satra commented Nov 8, 2024

sounds good.

@djarecka
Copy link
Member Author

perhaps I can change the migrate function to specific order, so it's easier to see the changes

@djarecka
Copy link
Member Author

I should change Field to Item

@djarecka
Copy link
Member Author

djarecka commented Jan 3, 2025

@yibeichan - have you had a chance to use the new activities in any protocol you are using?

@yibeichan yibeichan merged commit 9d6b865 into ReproNim:main Jan 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants