updates to the release GA #513
Conversation
| run: | | ||
| gen-pydantic --pydantic-version 2 linkml-schema/reproschema.yaml > reproschema_model_autogen.py | ||
| python scripts/fix_pydantic.py reproschema_model_autogen.py reproschema_model.py | ||
| pre-commit run --files reproschema_model.py |
There was a problem hiding this comment.
if the file is auto-generated we could just not lint it with pre-commit, but if we do then this step in workflow must have continue-on-error or an always
otherwise precommit will fail and stop everything: see here https://github.com/ReproNim/reproschema/actions/runs/9568185070/job/26377757321?pr=513#step:5:162
I think always() is the recommended way or that continue-on-error was deprecated
There was a problem hiding this comment.
we should run this at some point, since this will be later added to reproschema-py (and perhaps if we do it here it will be easier to automatically push to to reproschema-py)
| @@ -36,6 +36,33 @@ jobs: | |||
| python scripts/jsonParser.py | |||
| reproschema validate examples | |||
|
|
|||
| generate_other_formats: | |||
There was a problem hiding this comment.
note that this will generate the files on every PR but that they will no be added to the repo or the release
files generated on a given job are not passed the following ones in github action, so maybe better to have the file generation happen in the release job
There was a problem hiding this comment.
yes, I didn't get the structure at the beginning, just moved
There was a problem hiding this comment.
will be testing || true
@Remi-Gau @yibeichan - take a look if that makes sense, if it does we should merge to main and see if it generates the correct release PR when triggered