Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: finish setup of token list #1

Merged

Conversation

aimensahnoun
Copy link
Member

@aimensahnoun aimensahnoun commented Jan 8, 2025

Request Network Token List Setup

Overview

Initial setup of the Request Network Token List repository, providing a standardized way to manage and distribute token information across the Request Network ecosystem.

Changes

  • Token list schema and validation
  • Base token list with support for :
    - Fiat currencies (ISO4217)
    - ERC20 tokens
    - Native currencies
  • Github action workflows:
    - PR validation
    - Github pages deployment
  • Development tooling:
    - Biome for formatting and linting
    - Husky for git hooks
    - Vitest for testing

To do after PR is merged:

  • Update readme with the actual URL for the token list.

@aimensahnoun aimensahnoun marked this pull request as draft January 8, 2025 15:24
@MantisClone
Copy link
Member

Please add a description of the changes 🙏

@aimensahnoun aimensahnoun marked this pull request as ready for review January 9, 2025 10:34
@aimensahnoun aimensahnoun enabled auto-merge (squash) January 9, 2025 10:37
@aimensahnoun aimensahnoun disabled auto-merge January 9, 2025 10:37
@aimensahnoun aimensahnoun enabled auto-merge (squash) January 9, 2025 10:37
Copy link

@sstefdev sstefdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Just needs the conflict fixed 🚧

@aimensahnoun aimensahnoun disabled auto-merge January 9, 2025 12:12
@aimensahnoun aimensahnoun merged commit e28b412 into main Jan 9, 2025
1 check passed
@aimensahnoun aimensahnoun deleted the 269-support-request-network-token-list-in-invoice-dashboard branch January 9, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants