fix: pagination #328
fix: pagination #328
Conversation
WalkthroughThis pull request involves version updates across multiple packages within the Request Network ecosystem. The changes primarily focus on incrementing dependency versions and package versions for several packages, including Changes
Possibly Related PRs
Suggested Reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/invoice-dashboard/src/lib/view-requests.svelte (2)
499-501: Consider partial query invalidation instead of invalidating all queries
Invalidating all queries can be expensive if the app has multiple queries that don’t need to be refreshed. In most cases, you only need to invalidate and refetch a limited set of encryption-related queries.Here’s a sample diff showing how you might invalidate only “encryptedRequests” queries:
- queryClient.invalidateQueries() + queryClient.invalidateQueries(['encryptedRequests'])
524-526: Optimize query invalidation on decryption disable toggle
Similar to the “enable” side, using a targeted query key is more efficient than refetching everything. Confirm if other queries are truly impacted by disabling decryption.- queryClient.invalidateQueries() + queryClient.invalidateQueries(['encryptedRequests'])
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (6)
package.json(1 hunks)packages/create-invoice-form/package.json(2 hunks)packages/invoice-dashboard/package.json(2 hunks)packages/invoice-dashboard/src/lib/view-requests.svelte(2 hunks)packages/payment-widget/package.json(2 hunks)packages/single-invoice/package.json(2 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/invoice-dashboard/package.json
- packages/create-invoice-form/package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (5)
package.json (1)
33-33: Verify compatibility of updated currency library
Upgrading@requestnetwork/currencyto0.26.0looks fine, but confirm it doesn’t introduce breaking changes for your current usage.✅ Verification successful
Currency library update is compatible
The upgrade to@requestnetwork/[email protected]is safe based on consistent usage patterns and aligned dependencies with other Request Network packages.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check references to the updated library and gather approximate usage context rg -A 5 "@requestnetwork/currency"Length of output: 7727
Script:
#!/bin/bash # Check for changelog or release information curl -s "https://registry.npmjs.org/@requestnetwork%2Fcurrency/0.26.0" | jq '.description,.time["0.26.0"]' # Check dependencies alignment rg "\"@requestnetwork/types\":|\"@requestnetwork/utils\":" package.jsonLength of output: 228
Script:
#!/bin/bash # Check dependencies and their versions rg -A 3 '"dependencies": {' package-lock.json | rg "@requestnetwork" # Check actual usage patterns of CurrencyManager ast-grep --pattern 'new CurrencyManager($$$)'Length of output: 948
packages/single-invoice/package.json (2)
3-3: Patch version bump for your package
No issues observed. It follows semantic versioning for a patch.
36-38: Check for breaking changes in updated dependencies
Multiple dependencies (payment-detection, payment-processor, request-client.js) have bumped versions. Ensure functionality is tested to avoid regressions.✅ Verification successful
Minor version updates follow semantic versioning - no breaking changes expected
The version updates are all minor (0.x.0) which, according to semantic versioning, guarantee backward compatibility:
- @requestnetwork/payment-detection: 0.52.0
- @requestnetwork/payment-processor: 0.55.0
- @requestnetwork/request-client.js: 0.57.0
Code analysis confirms consistent API usage patterns across the codebase with no deprecated method calls.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify new dep versions usage rg -A 5 "@requestnetwork/payment-detection" rg -A 5 "@requestnetwork/payment-processor" rg -A 5 "@requestnetwork/request-client.js"Length of output: 24721
Script:
#!/bin/bash # Search for changelog files fd -i changelog fd -i release # Check package.json files for repository URLs to find GitHub locations rg -A 5 "repository.*:.*" package.jsonLength of output: 136
Script:
#!/bin/bash # Check root package.json cat package.json # Search for docs fd -t f -e md # Check recent commits for breaking changes git log --oneline -n 20Length of output: 1823
Script:
#!/bin/bash # Check READMEs for any upgrade-related content cat README.md cat CONTRIBUTING.md cat packages/*/README.md | grep -i -A 5 -B 5 "upgrad\|migrat\|breaking\|change"Length of output: 6649
packages/payment-widget/package.json (2)
3-3: Minor version bump
Version increment from 0.3.8 to 0.3.9 appears consistent.
59-61: Validate newly updated dependencies
Check whether these updated versions introduce any breaking changes or deprecations.✅ Verification successful
Dependencies verified - no breaking changes detected
The updated dependencies are being used consistently across multiple packages in the codebase, and there are no signs of version conflicts or breaking changes. The version updates appear to be minor bumps within the Request Network ecosystem, maintaining compatibility between the packages.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Searching references to newly updated dependencies rg -A 5 "@requestnetwork/payment-processor" rg -A 5 "@requestnetwork/request-client.js" rg -A 5 "@requestnetwork/web3-signature"Length of output: 22637
Script:
#!/bin/bash # Fetch package details and changelogs from npm echo "Checking @requestnetwork/[email protected]" curl -s https://registry.npmjs.org/@requestnetwork%2Fpayment-processor/0.55.0 | jq -r '.description, .time["0.55.0"]' echo -e "\nChecking @requestnetwork/[email protected]" curl -s https://registry.npmjs.org/@requestnetwork%2Frequest-client.js/0.57.0 | jq -r '.description, .time["0.57.0"]' echo -e "\nChecking @requestnetwork/[email protected]" curl -s https://registry.npmjs.org/@requestnetwork%2Fweb3-signature/0.8.8 | jq -r '.description, .time["0.8.8"]' # Check for README files that might contain version compatibility info echo -e "\nChecking for version compatibility documentation" fd -t f "README.md" | xargs rg -i "version|compatibility" -A 3Length of output: 6250
Script:
#!/bin/bash # Try to fetch release notes and changelogs from GitHub echo "Checking Request Network repository for release information" gh release view v0.55.0 -R RequestNetwork/requestNetwork 2>/dev/null || true gh release view v0.57.0 -R RequestNetwork/requestNetwork 2>/dev/null || true echo -e "\nSearching for CHANGELOG.md files" fd -t f "CHANGELOG.md" | xargs cat echo -e "\nChecking package dependencies for version constraints" fd -t f "package.json" -x jq -r '.dependencies | select(. != null) | to_entries[] | select(.key | startswith("@requestnetwork")) | "\(.key): \(.value)"'Length of output: 1137
Problem
Previous version of the SDK had an syntax issue with hinkal. Also, there was a problem with the caching of the queries.
Changes
Summary by CodeRabbit
Dependencies
@requestnetwork/currencyto version 0.26.0@requestnetwork/data-formatto version 0.19.8@requestnetwork/request-client.jsto version 0.57.0@requestnetwork/payment-detectionto version 0.52.0@requestnetwork/payment-processorto version 0.55.0@requestnetwork/web3-signatureto version 0.8.8Package Versions