Skip to content

Commit

Permalink
Fixed #15: Fix android specific pom so that library users don't have …
Browse files Browse the repository at this point in the history 
…to depend on dnsjava
  • Loading branch information
Antonis Tsakiridis committed Sep 25, 2017
1 parent 15c5529 commit a34b375
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion android-jain-sip-ext/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<groupId>dnsjava</groupId>
<artifactId>dnsjava</artifactId>
<version>2.1.7</version>
<scope>provided</scope>
<optional>true</optional>

This comment has been minimized.

Sign in to view

Copy link
@jaimecasero

jaimecasero Sep 25, 2017

Contributor

as discussed in channel, this will require redeclaration in android module. Alone it will not change anything. The fact we are using DNS classes in our android SDK is a general requirement for anyone using the android extension? It seems to me we are trying to push a particular solution issue into the project. What happens with the rest of project using android-jain.sip-ext which are not configured to use the DNS classes?
</dependency>

<dependency>
Expand Down

0 comments on commit a34b375

Please sign in to comment.