Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Fixed crash on tor profile generation on macOS #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[macOS] Fixed crash on tor profile generation on macOS #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tor/TorManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,7 @@ void RsTor::setHiddenServiceDirectory(const std::string& dir)

TorManager *RsTor::instance()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why this #ifdef is needed: if syscall(SYS_gettid) is not available, then we need to find some other way, because calling TorManager::instance() in a thread is not a good idea. If that happens, it means that the code that calls instance() is wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont know but now crash is solved and tor is started on macos,now on macos we can use tor with rs
but seems you added the if defs for windows too?, it was only for linux?

Copy link
Contributor Author

@defnax defnax Dec 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before i added the macos def i get warning in qt creator

TorManager.cpp:937:24: warning: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost().
unistd.h:745:6: note: 'syscall' has been explicitly marked deprecated here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google/glog#185

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the warning above is not a crash.
Was the crash due to the assert() call?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes reported by a user in rs network.
Look on the retroshare bugs forum

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well then it means 2 things:
1 - the assert is useful because it catches something that would cause deep trouble
2 - there is a bug because instance() shouldn't be called the first time from a thread

{
#if !defined(_WIN32) && !defined(__MINGW32__)
#if !defined(_WIN32) && !defined(__MINGW32__) && !defined(__APPLE__)
assert(getpid() == syscall(SYS_gettid));// make sure we're not in a thread
#endif

Expand Down