Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pilus hit effect utilizing cell burst effect #5247

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CI09
Copy link
Contributor

@CI09 CI09 commented Jun 22, 2024

Brief Description of What This PR Does

Related Issues

https://wiki.revolutionarygamesstudio.com/wiki/Release_Roadmap#0.6.x_(the_combat_and_part_upgrades_updates)

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@CI09 CI09 added the review label Jun 22, 2024
@CI09 CI09 added this to the Release 0.6.8 milestone Jun 22, 2024
@CI09 CI09 requested review from a team June 22, 2024 08:17
@revolutionary-bot
Copy link

The lead programmer for Thrive is currently on vacation until 2024-07-22. Until then other programmers will try to make pull request reviews, but please be patient if your PR is not getting reviewed.

PRs may be merged after multiple programmers have approved the changes (especially making sure to ensure style guide conformance and gameplay testing are good). If there are no active experienced programmers who can perform merges, PRs may need to wait until the lead programmer is back to be merged.

@CI09
Copy link
Contributor Author

CI09 commented Jun 22, 2024

Cell burst effect can be made more brighter but I'm waiting for others' opinion.

@HexapodPhilosopher
Copy link
Contributor

When I hit another cell using my pilus, the hit effect is centered on my cell rather than the point of contact. Also, the effect is far too big and slow. A version of the effect with an instant start and fewer particles that disappear after a shorter distance would be better.

@hhyyrylainen
Copy link
Member

hhyyrylainen commented Jul 22, 2024

I'll wait for visual tweaks on this before reviewing the code (as I think positioning logic being very different will warrant quite different technical implementation).

Edit: I'll say that I haven't looked in game but if this just uses the cell burst effect as is, it is very unsuitable for a fast action that can happen often.

A version of the effect with an instant start and fewer particles that disappear after a shorter distance would be better.

@revolutionary-bot
Copy link

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

@hhyyrylainen hhyyrylainen removed this from the Release 0.7.1 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

4 participants