Optimized CMake Build Process #5657
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Thisi file has wrong indentation and doesn't end with a newline, same with the other added cmake file in this folder. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| # Architecture detection | ||
| if(CMAKE_SIZEOF_VOID_P EQUAL 8) | ||
| set(THRIVE_ARCH "x64") | ||
| set(FLOAT_PRECISION "double") | ||
| add_definitions(-DTHRIVE_64_BIT) | ||
| else() | ||
| set(THRIVE_ARCH "x86") | ||
| set(FLOAT_PRECISION "single") | ||
| add_definitions(-DTHRIVE_32_BIT) | ||
| message(WARNING "32-bit build detected. Some features may not work correctly.") | ||
| endif() | ||
|
|
||
| # OS Detection | ||
| if(WIN32) | ||
| set(THRIVE_OS "windows") | ||
| else() | ||
| set(THRIVE_OS "linux") | ||
| endif() | ||
|
|
||
| # CPU core optimization | ||
| include(ProcessorCount) | ||
| ProcessorCount(CPU_CORES) | ||
| if(CPU_CORES EQUAL 0) | ||
| set(CPU_CORES 1) | ||
| elseif(CPU_CORES GREATER 4) | ||
| math(EXPR CPU_CORES "${CPU_CORES} - 1") | ||
| endif() | ||
|
|
||
| # Common compiler options | ||
| if(WIN32 AND MSVC) | ||
| add_compile_options( | ||
| /MP${CPU_CORES} | ||
| /bigobj | ||
| /GR | ||
| /EHsc | ||
| /nologo | ||
| ) | ||
|
|
||
| # Force consistent runtime | ||
| set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL") | ||
| endif() | ||
|
|
||
| # Target configuration functions | ||
| function(configure_windows_target target) | ||
| if(NOT WIN32 OR NOT MSVC) | ||
| message(FATAL_ERROR "function called on non-Windows/MSVC platform for target ${target}") | ||
| return() | ||
| endif() | ||
|
|
||
| target_compile_definitions(${target} PRIVATE | ||
| NOMINMAX | ||
| _CRT_SECURE_NO_WARNINGS | ||
| _HAS_EXCEPTIONS=1 | ||
| ) | ||
|
|
||
| # Create a Windows header that defines WIN32_LEAN_AND_MEAN | ||
| set(WIN32_HEADER "${CMAKE_BINARY_DIR}/windows_lean_mean.h") | ||
| file(WRITE ${WIN32_HEADER} "#ifndef WIN32_LEAN_AND_MEAN\n#define WIN32_LEAN_AND_MEAN\n#endif\n") | ||
|
|
||
| # Force include the header before any other includes | ||
| target_compile_options(${target} PRIVATE /FI"${WIN32_HEADER}") | ||
|
|
||
| set_target_properties(${target} PROPERTIES | ||
| MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>DLL" | ||
| ) | ||
|
|
||
| configure_unity_build(${target}) | ||
| endfunction() | ||
|
|
||
| function(configure_linux_target target) | ||
| if(WIN32) | ||
| message(FATAL_ERROR "configure_linux_target called on Windows platform") | ||
| return() | ||
| endif() | ||
|
|
||
| target_compile_options(${target} PRIVATE | ||
| -Wall | ||
| $<$<OR:$<CONFIG:Release>,$<CONFIG:Distribution>>:-O3> | ||
| ) | ||
|
|
||
| if(WARNINGS_AS_ERRORS) | ||
| target_compile_options(${target} PRIVATE -Werror) | ||
| endif() | ||
|
|
||
| set_target_properties(${target} PROPERTIES | ||
| POSITION_INDEPENDENT_CODE ON | ||
| ) | ||
| endfunction() | ||
|
|
||
| # Common target configuration function | ||
| function(configure_target_build target) | ||
| if(WIN32 AND MSVC) | ||
| configure_windows_target(${target}) | ||
|
|
||
| target_include_directories(${target} BEFORE PRIVATE | ||
| ${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES} | ||
| ${PROJECT_BINARY_DIR} | ||
| ) | ||
| else() | ||
| configure_linux_target(${target}) | ||
| endif() | ||
| endfunction() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # Print source files for a target (only if enabled) | ||
| function(print_source_files target) | ||
| if(NOT PRINT_SOURCE_FILES) | ||
| return() | ||
| endif() | ||
|
|
||
| get_target_property(target_sources ${target} SOURCES) | ||
| if(target_sources) | ||
| set(cpp_files "") | ||
| foreach(source ${target_sources}) | ||
| if(source MATCHES ".*\\.(cpp|cxx|cc)$") | ||
| get_filename_component(filename ${source} NAME) | ||
| list(APPEND cpp_files ${filename}) | ||
| endif() | ||
| endforeach() | ||
|
|
||
| list(LENGTH cpp_files total_files) | ||
| if(total_files GREATER 0) | ||
| list(SORT cpp_files) | ||
| message(STATUS "Files for ${target}:") | ||
| foreach(filename ${cpp_files}) | ||
| message(STATUS " ${filename}") | ||
| endforeach() | ||
| endif() | ||
| endif() | ||
| endfunction() | ||
|
|
||
| # Unity build configuration based on CPU cores | ||
| function(configure_unity_build target) | ||
| if(WIN32 AND MSVC) | ||
| if(CPU_CORES LESS 4) | ||
| set(UNITY_BATCH_SIZE 10) | ||
| elseif(CPU_CORES LESS 8) | ||
| set(UNITY_BATCH_SIZE 20) | ||
| else() | ||
| set(UNITY_BATCH_SIZE 30) | ||
| endif() | ||
|
|
||
| set_target_properties(${target} PROPERTIES | ||
| UNITY_BUILD ON | ||
| UNITY_BUILD_MODE GROUP | ||
| UNITY_BUILD_BATCH_SIZE ${UNITY_BATCH_SIZE} | ||
| ) | ||
| endif() | ||
| endfunction() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should copy the comment from where you moved this code (the reason why the non-standard distribution type is here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, i added something to it too :]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't see the comment text about Jolt requiring the Distribution type...