Improve visibility of membrane textures #5699
Conversation
| compress/hdr_compression=1 | ||
| compress/normal_map=0 | ||
| compress/channel_pack=0 | ||
| mipmaps/generate=false |
There was a problem hiding this comment.
3D textures should have mipmaps enabled for them, even though this is less critical than for 2D GUI images, I think it is still required ot make sure the texture looks good at small sizes (for example when viewing from far away).
There was a problem hiding this comment.
Okay. I was trying to get these to match the pre-existing ones, which had mipmaps disabled.
There was a problem hiding this comment.
The diff view it shows this PR also disables mipmaps for many existing textures... so if you looked at those for an example after they were changed that's were you would have gotten the incorrect picture.
| vec3 a = normalmap1*2.0 - 1.0; | ||
| vec3 b = normalmap2*2.0 - 1.0; |
There was a problem hiding this comment.
| vec3 a = normalmap1*2.0 - 1.0; | |
| vec3 b = normalmap2*2.0 - 1.0; | |
| vec3 a = normalmap1 * 2.0f - 1.0f; | |
| vec3 b = normalmap2 * 2.0f - 1.0f; |
Spaces should be used around operators to improve readability. Also shaders should really work with floats so numbers should be written preferrably with the f suffix (though I'm not always in the mood to nitpick about this).
| @@ -10,9 +10,10 @@ uniform sampler2D albedoTexture : source_color; | |||
| uniform sampler2D damagedTexture : source_color; | |||
|
|
|||
| uniform sampler2D normalTexture; | |||
| uniform sampler2D wiggleNormalTexture; | |||
There was a problem hiding this comment.
Why is this called "wiggleNormal"? As far as I can see there isn't a difference between the first normal map and the second in terms of wiggle (both seem to be now affected by it). Is there a typo perhaps or did you just mean to have two normal maps? In the latter case I think the variable needs renaming (and the relevant variables in the membrane C# code).
There was a problem hiding this comment.
The idea was to have them move separately, although I'm not sure there's a need for it. I'll look at making it move relative to the other normal. The alternative would be reverting most of the shader changes and making the new normals more bumpy.
There was a problem hiding this comment.
If you didn't mean to break a fix by @dligr the normal bump map is supposed to use UV2 and not just the first UV. So if you redo that change to preserve that, then this would all make sense as the second bump map would be affected by the wiggles and the first one wouldn't be.
Brief Description of What This PR Does
Adds new membrane textures, making different cell types more visually distinct.
Adds new, unique normals for the membrane types.
Changes shader to combine the unique and shared membrane normals.
Related Issues
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.