Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extinct species not having preview in auto-evo exporer #5701

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

dligr
Copy link
Member

@dligr dligr commented Nov 22, 2024

Brief Description of What This PR Does

Fixes extinct species not having previews in auto-evo exporer

Related Issues

Fixes #5435

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@dligr dligr added the review label Nov 22, 2024
@dligr dligr added this to the Release 0.8.0 milestone Nov 22, 2024
@dligr dligr requested review from a team November 22, 2024 19:03
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few more small code related comments.

src/gui_common/PhotographablePreview.cs Outdated Show resolved Hide resolved
src/gui_common/SpeciesDetailsPanelWithFossilisation.cs Outdated Show resolved Hide resolved
src/gui_common/SpeciesPreview.cs Show resolved Hide resolved
src/microbe_stage/CellHexesPreview.cs Show resolved Hide resolved
src/thriveopedia/ThriveopediaManager.cs Outdated Show resolved Hide resolved
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good to me now. I'll assume you've tested this enough as no one else is likely to playtest this and I don't have time right now.

@hhyyrylainen hhyyrylainen merged commit b6b3f54 into master Nov 26, 2024
4 checks passed
@hhyyrylainen hhyyrylainen deleted the extinct_preview branch November 26, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Pressing on extinct species in auto-evo explorer report doesn't show information about this species
2 participants