Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update features.py #128

Closed
wants to merge 1 commit into from
Closed

Update features.py #128

wants to merge 1 commit into from

Conversation

renaudponcelet
Copy link
Contributor

make the looking for pi feature able to handle expression with pi in it like in "2*pi/5 - 0.2" for instance

@renaudponcelet
Update features.py
a56ba31 
make the looking for pi feature able to handle expression with pi in it like in "2*pi/5 - 0.2" for instance
@Gregwar
Copy link
Contributor

Gregwar commented Feb 20, 2025

To be honest, I am not a big fan of running eval(). This is both a possible source of bug and possible security issues.
Maybe we need to find some parser to handle those expressions in a better way

Gregwar added a commit that referenced this pull request Mar 4, 2025
@Gregwar
Reading expressions using ast (see #140, #128)
cb47c35
@Gregwar
Copy link
Contributor

Gregwar commented Mar 4, 2025

Just pushed an update in 1.4.2 with a better reading of expressions based on ast module

@Gregwar Gregwar closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renaudponcelet @Gregwar