Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Install NBDime #132

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Install NBDime #132

wants to merge 3 commits into from

Conversation

delgadom
Copy link
Member

@delgadom delgadom commented Jul 27, 2020

Workflow

  • Closes issue Install NBDIME notebook diff plugin #133
  • Notebook:worker pairing builds & passes local build, visual inspection & client.map tests
  • Passes travis tests
  • Image deployed on dev branch (see notebook and worker dev tags)
  • Worker passes manual deployment test on compute.rhg
  • Notebook+worker passes test-hub deployment
  • Updates integrated into downstream images

Summary

Installs the nbdime package & plugin for computing and viewing jupyter notebook diffs in an interactive widget.

@delgadom delgadom changed the title Update notebook_environment.yml Install NBDime Aug 5, 2020
@delgadom delgadom requested a review from bolliger32 August 5, 2020 00:52
@delgadom
Copy link
Member Author

delgadom commented Aug 5, 2020

@bolliger32 this similar to what worked on the pyTC image?

@bolliger32
Copy link
Collaborator

Yup! Only a couple minor differences. Instead of nbdime extensions --enable I called jupyter serverextensions enable --py nbdim --sys-prefix. I'm trying to remember why... I think sys-prefix was needed b/c of some weirdness about where I was calling it and permissions between root and jovyan users. And I think I just called serverextensions enable b/c the labextension was already installed as part of the conda package. But I think the nbdime extensions command should do the same thing.

@delgadom
Copy link
Member Author

delgadom commented Aug 5, 2020

huh yeah - they say that the nbdime extensions --enable command is equivalent to the following (not sure which sys-prefix/user/system is actually called):

jupyter serverextension enable --py nbdime [--sys-prefix/--user/--system]

jupyter nbextension install --py nbdime [--sys-prefix/--user/--system]
jupyter nbextension enable --py nbdime [--sys-prefix/--user/--system]

jupyter labextension install nbdime-jupyterlab

@bolliger32 you think the last line isn't necessary? It seems to be building just fine - were you getting the errors on jupyterlab load?

@bolliger32
Copy link
Collaborator

@delgadom Yeah I think the conda install does the labextension install itself. So I think it's not necessary but also doesn't hurt. So if it's building and runs properly, I think it's it's good!

@bolliger32
Copy link
Collaborator

I noticed we also need to jump through a few more hoops to make the web tool use an accessible IP address by default. See latest commit and https://nbdime.readthedocs.io/en/latest/config.html and https://nbdime.readthedocs.io/en/latest/vcs.html#git-integration

@bolliger32
Copy link
Collaborator

hmm i think we also might need to bump gitpython to make the nbdime config-git command work. Or we'd have to do some manual git config file adjustments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants