Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

add pydap to conda forge dependencies #137

Merged
merged 1 commit into from
Aug 11, 2020
Merged

add pydap to conda forge dependencies #137

merged 1 commit into from
Aug 11, 2020

Conversation

dgergel
Copy link
Contributor

@dgergel dgergel commented Aug 8, 2020

Workflow

Summary

Adds pydap to the list of dependencies. Required for downloading some obs data and using the engine='pydap' argument with open_mfdataset in xarray.

@dgergel dgergel requested review from brews and delgadom August 8, 2020 00:00
@dgergel dgergel self-assigned this Aug 8, 2020
Copy link
Member

@delgadom delgadom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just checking - where did the release ID come from? Did you copy this from conda-forge or from the installed version on your jupyterlab server?

@dgergel
Copy link
Contributor Author

dgergel commented Aug 10, 2020

@delgadom I installed it with conda-forge and then used the release ID from that installation (I had previously installed it with pip). Does that seem right?

@delgadom
Copy link
Member

yep! nicely done!

@delgadom delgadom merged commit c1f7457 into master Aug 11, 2020
@delgadom delgadom deleted the add_pydap branch August 11, 2020 05:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants