Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use and support NET 8 SDK artifacts output #4589

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

lahma
Copy link
Collaborator

@lahma lahma commented Nov 19, 2023

Use the new NET 8 SDK artifacts output layout feature which consolidates bin and obj folders under artifacts directory. Need to move Directory.Build.props to root level for proper configuration.

To remove old cruft, might be good idea to run locally in solution root directory:

Get-ChildItem .\ -include bin,obj -Recurse | foreach ($_) { remove-item $_.fullname -Force -Recurse }

This also improves the project metadata querying by trying to use the new CLI-based metadata querying , basically obj folder can now be anywhere and no need to give extensions path like before (for artifacts output enabled projects it would always fail). New retrieval should be faster too. If NET 8 SDK is not present, old logic will be used.

@lahma lahma force-pushed the artifacts-output branch 3 times, most recently from c78fbdf to ba58e97 Compare November 20, 2023 08:46
@lahma lahma requested a review from RicoSuter November 20, 2023 09:00
@lahma lahma changed the title Use NET 8 SDK artifacts output Use and support NET 8 SDK artifacts output Nov 20, 2023
@RicoSuter RicoSuter merged commit be967b4 into RicoSuter:master Nov 21, 2023
1 check passed
@RicoSuter
Copy link
Owner

lgtm. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants