Skip to content

Commit

Permalink
Aggregate using count_distinct to resolve error
Browse files Browse the repository at this point in the history
The error got in `mf validate-configs`:
> ✖ Breaking issues found when checking semantics of built manifest (ERRORS: 8, FUTURE_ERRORS: 0, WARNINGS: 0)
> • ERROR: with metric `mql_to_seller_conversion_rate_1_week_window`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: mqls is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_1_week_window`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: sellers is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_7_day_window`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: mqls is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_7_day_window`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: sellers is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_7_day_window_with_filter`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: mqls is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_7_day_window_with_filter`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: sellers is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_base`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: mqls is agg type: AggregationType.SUM
> • ERROR: with metric `mql_to_seller_conversion_rate_base`  - For conversion metrics, the measure must be COUNT/SUM(1)/COUNT_DISTINCT. Measure: sellers is agg type: AggregationType.SUM
  • Loading branch information
Rindrics committed Mar 3, 2024
1 parent 077fad9 commit 1737829
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion models/marts/ecommerce/olist_closed_deals.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ semantic_models:
type: categorical
measures:
- name: sellers
agg: count
agg: count_distinct
expr: seller_id
create_metric: true
metrics:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ semantic_models:
type: categorical
measures:
- name: mqls
agg: count
agg: count_distinct
expr: mql_id
metrics:
- name: mqls
Expand Down

0 comments on commit 1737829

Please sign in to comment.