Upgrades AWS SDK to V2 #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit upgrades the AWS SDK to version 2 and adds a test suite for testing artifact deploys with Amazon s3. To test the artifact deploys, you'll need to create a databag for that test suite and/or deploy to Amazon. First, it will try to authorize the user through databags. If it is unable to find an aws databag, it will switch to using the instance profile to pull the informmation directly from the Amazon EC2 instance.
|
👍 Great work. This is much needed. I was about to do this myself and submit a PR. It would be great to have the version of the SDK as an attribute. I have other cookbooks that use a newer version and don't want to install different versions unnecessarily. |
|
Will be great if this can be merged! |
|
Can we merge? We are still using this cookbook. |
alejandrod
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades the AWS SDK to version 2 and adds a test suite for testing artifact deploys with Amazon s3.