Add option to provide custom user transformer #1103
Conversation
Signed-off-by: Iana Kotreleva <[email protected]>
Signed-off-by: Iana Kotreleva <[email protected]>
|
Fantastic thank you for this. It looks great. Would you mind adding to the groups as well? |
|
Yes, of course! I will add this for groups as well 👍 |
|
@kissmikijr Hey! I added functionality to the groups as well and also updated the documentation. Would be nice if you could take a look once you have time. Thanks! |
| metadata: expect.objectContaining({ | ||
| name: 'asdfwefwefwef', | ||
| description: 'Everyone in the company', |
There was a problem hiding this comment.
Shouldn't we add the annotations to this as well?
There was a problem hiding this comment.
Sorry, I am not sure I understand. Do you mean to check annotations object in metadata? The untransformed group doesn't have any custom annotations that's why I didn't add any checks here. Only for the new profile.displayName which isn't available in the default transformer
| export type OktaGroupEntityTransformer = ( | ||
| group: OktaGroup, | ||
| namingStrategy: GroupNamingStrategy, | ||
| parentGroup: OktaGroup | undefined, |
There was a problem hiding this comment.
I think we could make parentGroup optional so we dont need to write out the explicit undefined here
| parentGroup: OktaGroup | undefined, | |
| parentGroup?: OktaGroup, |
This PR adds an option to provide a custom user transformer for okta users in user and org providers. It is a similar feature that LDAP has. If the transformer is provided it will be used instead of userEntityFromOktaUser.
In our use case, we want to fill some of the fields of the user entity which isn't possible to do now. For example,
profile.pictureormetadata.description.Something similar was discussed in this issue #900
If this approach is accepted, I can also do that for groups.
✔️ Checklist
yarn changesetin the root)