Dynamic prometheus #1127
Merged
Dynamic prometheus #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Forbis <[email protected]>
Signed-off-by: Brian Forbis <[email protected]>
Signed-off-by: Brian Forbis <[email protected]>
bforbis
commented
Sep 21, 2023
| ## Using callback with `EntityPrometheusAlertCard` | ||
|
|
||
| You can add callbacks that will be executed when the user clicks on a row in the table of the `EntityPrometheusAlertCard` component. This callback is optional, and the rows become clickable only when the callback is supplied. The callback function is also provided with data of type JSON. It contains the information from the row of the table. | ||
| The component with callback can look like this: | ||
|
|
||
| ```typescript | ||
| <EntityPrometheusAlertCard onRowClick={callbackFunction} /> | ||
| ``` | ||
| ```` |
There was a problem hiding this comment.
Looks like I screwed up the code fence. Will fix this.
Signed-off-by: Brian Forbis <[email protected]>
Xantier
reviewed
Sep 21, 2023
| Step 2: Hijack this path by writing your own proxy middleware extension. | ||
| **packages/backend/src/plugins/proxy.ts** | ||
|
|
||
| ````diff |
There was a problem hiding this comment.
Suggested change
| ````diff | |
| ```diff |
Signed-off-by: Brian Forbis <[email protected]>
Signed-off-by: Brian Forbis <[email protected]>
|
CI run seems to not have downloaded Cypress correctly. |
Yup, GitHub does tht sometimes. I'll kick it off again |
Xantier
approved these changes
Sep 22, 2023
|
@Xantier thanks for merging :) Just curious, do you have a scheduled date this will be released? |
|
Was thinking of releasing it with upgrades to 1.18, but I just shipped this now as a standalone shipment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1125
✔️ Checklist
yarn changesetin the root)