Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Consistently indent with 2 spaces #755

Merged
merged 1 commit into from
Dec 11, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@

## Pre-requisites/assumptions

* Your project uses `git`

Check failure on line 15 in README.md

View workflow job for this annotation

GitHub Actions / QA Checks (README Linting [8.1, locked], ubuntu-latest, laminas/laminas-continuous-integration-ac...

Unordered list indentation [Expected: 0; Actual: 1]
* Your project uses `composer.json` to define its dependencies

Check failure on line 16 in README.md

View workflow job for this annotation

GitHub Actions / QA Checks (README Linting [8.1, locked], ubuntu-latest, laminas/laminas-continuous-integration-ac...

Unordered list indentation [Expected: 0; Actual: 1]
* All source paths are covered by an `"autoload"` section in `composer.json`

Check failure on line 17 in README.md

View workflow job for this annotation

GitHub Actions / QA Checks (README Linting [8.1, locked], ubuntu-latest, laminas/laminas-continuous-integration-ac...

Unordered list indentation [Expected: 0; Actual: 1]
* Changes need to be committed to `git` to be covered. You can implement your own logic to extract sources and dependencies from a project though.

Check failure on line 18 in README.md

View workflow job for this annotation

GitHub Actions / QA Checks (README Linting [8.1, locked], ubuntu-latest, laminas/laminas-continuous-integration-ac...

Unordered list indentation [Expected: 0; Actual: 1]

## Installation

Expand All @@ -25,7 +25,7 @@

### Install with Docker

You can also use Docker to run `roave-backward-compatibility-check`:

Check failure on line 28 in README.md

View workflow job for this annotation

GitHub Actions / QA Checks (README Linting [8.1, locked], ubuntu-latest, laminas/laminas-continuous-integration-ac...

Trailing spaces [Expected: 0 or 2; Actual: 1]

```bash
docker run --rm -v `pwd`:/app nyholm/roave-bc-check
Expand Down Expand Up @@ -58,19 +58,19 @@
jobs:
roave-backwards-compatibility-check:
name: Roave Backwards Compatibility Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: "Install PHP"
uses: shivammathur/setup-php@v2
with:
php-version: "8.0"
- name: "Install dependencies"
run: "composer install"
- name: "Check for BC breaks"
run: "vendor/bin/roave-backward-compatibility-check"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: "Install PHP"
uses: shivammathur/setup-php@v2
with:
php-version: "8.0"
- name: "Install dependencies"
run: "composer install"
- name: "Check for BC breaks"
run: "vendor/bin/roave-backward-compatibility-check"
```

#### Nyholm Github Action
Expand All @@ -79,8 +79,8 @@
that you can use in your Github pipeline. We recommend this for most cases as
it is simple to set up:

_.github/workflows/main.yml_

Check failure on line 82 in README.md

View workflow job for this annotation

GitHub Actions / QA Checks (README Linting [8.1, locked], ubuntu-latest, laminas/laminas-continuous-integration-ac...

Emphasis used instead of a heading [Context: ".github/workflows/main.yml"]
```yaml

Check failure on line 83 in README.md

View workflow job for this annotation

GitHub Actions / QA Checks (README Linting [8.1, locked], ubuntu-latest, laminas/laminas-continuous-integration-ac...

Fenced code blocks should be surrounded by blank lines [Context: "```yaml"]
on: [push]
name: Test
jobs:
Expand Down
Loading