[Feature] Implemented like doctrine/doctrine-bundle's ContainerRepositoryFactory.
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
added
enhancement
|
This looks +1 in principle, but I think we need some docs added in here on usage. Added |
1 task
asgrim
reviewed
Sep 9, 2021
README.md
Outdated
|
|
||
| /** @var ContainerRepositoryFactory $respositoryFactory */ | ||
| $respositoryFactory = $container->get(ContainerRepositoryFactory::class); | ||
| $respository2 = $respositoryFactory->getRepository($em, FooEntity::class); |
There was a problem hiding this comment.
I'm not sure I see the benefit of having this method of obtaining a repository, given the methods to retrieve $repository works out of the box, and $repository3 is already simple enough with any container anyway? Maybe I missed something? 🤔
There was a problem hiding this comment.
Change the document for what the service injected.
…features/container-repository-factory # Conflicts: # .travis.yml # src/DriverFactory.php # test/ConnectionFactoryTest.php
…tainer-repository-factory # Conflicts: # composer.lock
Update docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
ContainerRepositoryFactory. See #28Diff with
doctrine/doctrine-bundle'sContainerRepositoryFactory.ServiceEntityRepositoryInterface.Documentation
Sorry, my not freely English, if the guide is an inappropriate hope that someone will correct.