Support for destination file rename #46
Conversation
…oved username and password out of Gruntfile and into .ftpauth file
Added example targets to initConfig code, lack of a target results in error in Grunt.
Added example targets to initConfig code, lack of a target results in error in Grunt.
Updated README.md Good catch, thanks.
Updated README.md Good catch, thanks.
…aned up and refactored code, bug fix mentioned in Robert-W#9
…test with more iterations
Fix issue: empty folder structure are being created.
A lot of duplicates were generated for all files in the same folder. This should speed up the process.
De-duplicate destination directories
Handle errors the grunt way
Optimize de-duplication
There was a problem hiding this comment.
Thanks for all the work here. It's been a while, and I'm a new contributor, so sorry this took so long to get a good look at.
This needs a few adjustments, and a merge down before it can be tested again. If you're still interested in doing so, I'd be happy to look at it again after that.
Oh, also, you'll want to configure your IDE to add line endings at the end of the file:
Change your Editor settings:
Settings → Editor → General → Ensure line feed at file end on Save
| @@ -1,3 +1,3 @@ | |||
| node_modules | |||
| npm-debug.log | |||
| tmp | |||
| .DS_Store | |||
There was a problem hiding this comment.
Can you please add .idea/ to this list, and then remove the .DS_Store and .idea/* files from your PR?
| ] | ||
| }, | ||
|
|
||
| sample: { |
There was a problem hiding this comment.
Not entirely sure we'd need a whole sample area here just to show the new option, to be honest. Can you please add the debug and new files[] options as items in the README.md instead?
| grunt.registerTask('test', ['ftp_push']); | ||
| grunt.registerTask('sample', ['ftp_push:sample']); |
There was a problem hiding this comment.
We can remove this if we're removing the sample from above.
Hi,
I've added the support for destination path in which the target filename is different from the source filename (using grunt src-dest format).
Thanks,
Luciano