added a script for computing contract addresses #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| contract ComputeContractAddresses is Script { | ||
| address public deployedWalletAddress; | ||
|
|
||
| address constant public create2DeployerAddress = 0x13b0D85CcB8bf860b6b79AF3029fCA081AE9beF2; |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: compound.solidity.constant-not-in-uppercase Note
| function run() external { | ||
| uint256 passedChainId = vm.envUint("CHAIN_ID"); | ||
|
|
||
| require(block.chainid == passedChainId, "Chain ID mismatch"); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.performance.use-custom-error-not-require Note
RobinNagpal
commented
Oct 21, 2024
| }: SourceTokenParameters) { | ||
| let amount = BigNumber.from(amount_); | ||
| if (amount.isZero()) { | ||
| return; | ||
| } else if (amount.isNegative()) { | ||
| await removeTokens(dm, amount.abs(), asset, address); | ||
| } else { | ||
| await addTokens(dm, amount, asset, address, [address].concat(blacklist)); | ||
| if(blockNumber) { |
There was a problem hiding this comment.
remove extra if statement
RobinNagpal
commented
Oct 21, 2024
scenario/RewardsScenario.ts
Outdated
| 100000, | ||
| rewardTokenAddress, | ||
| newRewards.address, | ||
| 2751700 |
There was a problem hiding this comment.
Add comment for these values. Why these values?
RobinNagpal
commented
Oct 21, 2024
| @@ -63,7 +63,7 @@ export class ProposalConstraint<T extends CometContext> implements StaticConstra | |||
| } | |||
|
|
|||
| // temporary hack to skip proposal 329 | |||
| if (proposal.id.eq(329)) { | |||
| if (proposal.id.eq(349) || proposal.id.eq(350)) { | |||
RobinNagpal
commented
Oct 21, 2024
scenario/context/CometContext.ts
Outdated
| address: recipientAddress, | ||
| blacklist: [comet.address], | ||
| }); | ||
| if (blockNumber) { |
There was a problem hiding this comment.
Extra if statement can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.