This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Remove trimming from tracing #387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original code said there was no to specify a trace level without also specifying a message, but you can just set the message to nil to achieve this. This change makes it so we don't have to trim the traceback to remove the newline.
ewd3v
changed the title
Awokein
approved these changes
Sep 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original code said there was no way to specify a trace level without also specifying a message, but you can just set the message to nil to achieve this.
This change makes it so we don't have to trim the traceback to remove the newline.
Checklist before submitting:
CHANGELOG.md