Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Receptionist] updates for the challenge #930
[Receptionist] updates for the challenge #930
Changes from 6 commits
895b781
a900068
2390b6d
0ede20a
ef1a078
773a739
7077fe2
0c3efad
606d4f6
ae2bfea
2539b76
e76fe7f
761cff0
5211114
6cf794a
f54b80e
2c6b904
dd556ab
16acc25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems very weird. And kinda difficult for volunteers who might already have trouble interacting with the robot. In my experience proper tracking can usually be checked here regardless because people will turn to the referee, step towards the robot, bend down to the robot etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was that also discussed in the TC meeting? Cause i was specifically told that this should be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was specifically requested above in order to make sure the robot keeps eye-contact. It might be enough if one person does this just to see that the robot is capable of keeping tracking on them. If we hand out post-its with Name, Drink, Interest, it should be fine I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what we talked in the TC meeting is that is must be added one way or the other, a lot of robots don't do this and many times robots are talking to a person, the person moves aw bit and the robot keeps looking to an empty space. This just seems very weird. As @hawkina said, doing this with one person is enough to understand if the robot does dynamic tracking or not.