Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Small post-General interest cleanup #78

Merged
merged 9 commits into from
Sep 9, 2024
Merged

fix: Small post-General interest cleanup #78

merged 9 commits into from
Sep 9, 2024

Conversation

evan10s
Copy link
Member

@evan10s evan10s commented Sep 8, 2024

Fixes several small things from recent feedback:

  • Update to AGP 8.6.0 / Gradle 8.9
  • Log more invalid NFC taps as warnings so more info is sent to Sentry
  • Cleanup variable name in NFC handler for clarity (desfireEV1 -> desfire)
  • The events list for attendance is now sorted by start date in descending order. Events where the start date is null sort to the bottom
  • Uses new endpoint to get details for just the selected merch item on the distribution screen
  • Better error handling for the edge case where a merch item becomes undistributable between the time the list of merch items is loading and when the item is selected:

@evan10s evan10s changed the title Update to AGP 8.6.0 / Gradle 8.9 feat: Update to AGP 8.6.0 / Gradle 8.9 Sep 8, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@evan10s evan10s changed the title feat: Update to AGP 8.6.0 / Gradle 8.9 fix: Small post-General interest cleanup Sep 8, 2024
@evan10s evan10s requested a review from kberzinch September 8, 2024 19:14

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Sep 8, 2024

Download PR build v1.5.1-PullRequest0078.10

PR builds are unsigned and always use version code 1. Follow these steps to enable installing them on your device.

@evan10s evan10s merged commit 950d282 into main Sep 9, 2024
7 checks passed
@evan10s evan10s deleted the evan/small-fixes branch September 9, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve attendance events list ordering
2 participants