Cleanup external prereqs #334
Conversation
nicolecheetham
force-pushed
the
extprereq_cleanup
branch
from
6a29dfa
to
28420ba
Compare
There was a problem hiding this comment.
This aimed in the wrong direction. See below.
Reviewable status: 2 unresolved discussions, platform LGTM missing (waiting on @nicolecheetham)
drake_bazel_external/setup/install_prereqs line 54 at r1 (raw file):
wget -O drake.tar.gz \ https://drake-packages.csail.mit.edu/drake/nightly/drake-latest-jammy.tar.gz
This (and the call to the unzipped install_prereqs about 10 lines later) is entirely wrong. It's downloading the binary release, which not NOT be part of building Drake from source.
This script should be downloading a source copy of Drake, and then shelling out to the source copy of install_prereqs.
drake_cmake_external/setup/install_prereqs line 54 at r1 (raw file):
wget -O drake.tar.gz \ https://drake-packages.csail.mit.edu/drake/nightly/drake-latest-jammy.tar.gz
This (and the call to the unzipped install_prereqs about 10 lines later) is entirely wrong. It's downloading the binary release, which not NOT be part of building Drake from source.
This script should be downloading a source copy of Drake, and then shelling out to the source copy of install_prereqs.
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, platform LGTM missing (waiting on @jwnimmer-tri and @nicolecheetham)
drake_bazel_external/setup/install_prereqs line 54 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
This (and the call to the unzipped
install_prereqsabout 10 lines later) is entirely wrong. It's downloading the binary release, which not NOT be part of building Drake from source.This script should be downloading a source copy of Drake, and then shelling out to the source copy of
install_prereqs.
Nicole, take a look at drake_bazel_external/setup/install_prereqs in #313 (draft), I was able to remove all but one or two explicit installs after calling source copy of install_prereqs.
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, platform LGTM missing (waiting on @jwnimmer-tri and @nicolecheetham)
drake_bazel_external/setup/install_prereqs line 54 at r1 (raw file):
Previously, BetsyMcPhail (Betsy McPhail) wrote…
Nicole, take a look at
drake_bazel_external/setup/install_prereqsin #313 (draft), I was able to remove all but one or two explicit installs after calling source copy ofinstall_prereqs.
It's still feels not-quite-right as the CMake then adds drake as an external project (
) and gets the source again.There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, platform LGTM missing (waiting on @BetsyMcPhail and @nicolecheetham)
drake_bazel_external/setup/install_prereqs line 54 at r1 (raw file):
Previously, BetsyMcPhail (Betsy McPhail) wrote…
It's still feels not-quite-right as the CMake then adds drake as an external project (
) and gets the source again.
Ah. Maybe we should just close this PR and work on finishing up #313 instead?
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions, platform LGTM missing (waiting on @jwnimmer-tri and @nicolecheetham)
drake_bazel_external/setup/install_prereqs line 54 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Ah. Maybe we should just close this PR and work on finishing up #313 instead?
That's fine with me, I haven't quite worked out the best way to structure the external examples. But there's more work beyond just the install_prereqs.
Removes unneeded packages in the external install_prereqs
This change is