Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made changes to replace deprecated methods in standard #225

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

NikhilSuresh24
Copy link
Member

Changed several files to remove calls of deprecated methods

Copy link
Member

@Daniel-E-B Daniel-E-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@@ -1,7 +1,6 @@
package org.usfirst.frc4904.standard.custom.sensors;


import org.usfirst.frc4904.standard.LogKitten;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than getting rid of this, maybe consider logging navx errors?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be a diff branch

Copy link
Contributor

@oshlern oshlern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for testing! Looks good as long as it actually works.

@b-cho b-cho self-requested a review December 7, 2019 01:03
Copy link
Contributor

@b-cho b-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok—not tested but I don't know how to test it because there are no visible differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants