-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file type filtering dropdown to improve file navigation #718
Merged
Spiral-Memory
merged 4 commits into
RocketChat:develop
from
SinghaAnirban005:feat/filter
Jan 11, 2025
Merged
feat: add file type filtering dropdown to improve file navigation #718
Spiral-Memory
merged 4 commits into
RocketChat:develop
from
SinghaAnirban005:feat/filter
Jan 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good @SinghaAnirban005 Instead of keeping that select below search, keep both in a single row |
SinghaAnirban005
force-pushed
the
feat/filter
branch
from
January 3, 2025 14:28
6303804
to
8f6d3f9
Compare
After changes in layout EmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2025-01-04.01-55-26.mp4 |
SinghaAnirban005
force-pushed
the
feat/filter
branch
from
January 10, 2025 17:50
6834c16
to
c2703c7
Compare
SinghaAnirban005
force-pushed
the
feat/filter
branch
from
January 11, 2025 14:39
c2703c7
to
24147ee
Compare
@Spiral-Memory EmbeddedChat._.Simple.-.Simple.Storybook.-.Personal.-.Microsoft.Edge.2025-01-11.20-44-42.mp4 |
Spiral-Memory
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Title
Implement File Type Filtering Dropdown
Acceptance Criteria fulfillment
Fixes #717
Video/Screenshots
EmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2024-12-23.19-25-59.mp4
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-718 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.