Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added a conditional check before showing Avatar in attachments #788

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 3, 2025

Brief Title

Acceptance Criteria fulfillment

  • Now when avatar is set to false inside addons then attached items's docs not show avatar

Fixes #787

Video/Screenshots

Screencast.from.2025-01-04.01-05-18.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@abirc8010
Copy link
Contributor

abirc8010 commented Jan 3, 2025

Hey @thepiyush-303,
I noticed that the video you uploaded might not correspond to the changes in this PR. Could you update the PR description with:

  1. A highlight of the changes made.
  2. The correct video showcasing the implemented fixes.
  3. Also link your PR with the issue

@thepiyush-303
Copy link
Contributor Author

Hey @thepiyush-303, I noticed that the video you uploaded might not correspond to the changes in this PR. Could you update the PR description with:

1. A highlight of the changes made.

2. The correct video showcasing the implemented fixes.

3. Also link your PR with the issue

Thanks, @abirc8010 for letting me know it was showing now i update it.
also i see a minor css issue i'll commit it soon

@thepiyush-303 thepiyush-303 changed the title Added a conditional check before showing Avatar in attachments feat: Added a conditional check before showing Avatar in attachments Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserIcon does not hide if showAvatar addon is set to false
2 participants