-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a Preview Feature to check the text after formatting it. #889
base: develop
Are you sure you want to change the base?
Conversation
…mbeddedChat into feat/previewText
@Spiral-Memory |
Hey @thepiyush-303, this is good feature to get implemented, LGTM ! 🎉 |
Thankyou, @devanshkansagra |
Hi @thepiyush-303 , this seems like a nice addition 🚀 ! |
the markup you are talking about needs |
@@ -25,6 +25,7 @@ | |||
"typescript": "^5.1.3" | |||
}, | |||
"dependencies": { | |||
"dompurify": "^3.1.6" | |||
"dompurify": "^3.1.6", | |||
"marked": "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He might be talking about this thing i.e marked
Brief Title
I need to provide users with a preview option for formatted messages before sending them,
So that they can review and ensure the message appears as intended.
Fixes #890
Video/Screenshots
Screencast.from.2025-01-13.20-59-12.webm
PR Test Details
Hey @Spiral-Memory,
I'm not sure if this is necessary, but as a user, I wanted this feature in RC, so I started working on it without considering the requirement. If it turns out that it's not needed, please leave feedback on my changes.
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-889 after approval. Contributors are requested to replace
<pr_number>
with the actual PR number.